D18920: Fix PCI module

2019-08-01 Thread Christoph Feck 
This revision was automatically updated to reflect the committed changes.
Closed by commit R102:8056039c7947: Fix PCI module (authored by konradr, 
committed by cfeck).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18920?vs=61562=62955

REVISION DETAIL
  https://phabricator.kde.org/D18920

AFFECTED FILES
  Modules/pci/kpci_private.h

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D18920: Fix PCI module

2019-07-11 Thread Konrad Rzepecki 
konradr updated this revision to Diff 61562.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18920?vs=61495=61562

REVISION DETAIL
  https://phabricator.kde.org/D18920

AFFECTED FILES
  Modules/pci/kpci_private.h

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D18920: Fix PCI module

2019-07-10 Thread Christoph Feck 
cfeck added inline comments.

INLINE COMMENTS

> kpci_private.h:48
>  
> +/* Following structurs MUST BE packed, otherwise variables will be mapped to
> +   wrong places. Q_PACKED macro seems not work very well. `#pragma pack` are

structure or structures?

> kpci_private.h:49
> +/* Following structurs MUST BE packed, otherwise variables will be mapped to
> +   wrong places. Q_PACKED macro seems not work very well. `#pragma pack` are
> +   more widely adopted, and should be ignored if not supported.

seems to

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D18920

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D18920: Fix PCI module

2019-07-10 Thread Konrad Rzepecki 
konradr updated this revision to Diff 61495.
konradr retitled this revision from "Fix and update PCI module" to "Fix PCI 
module".
konradr edited the summary of this revision.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18920?vs=51397=61495

REVISION DETAIL
  https://phabricator.kde.org/D18920

AFFECTED FILES
  Modules/pci/kpci_private.h

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart