D18964: UpdatesPage: Fix icon sizing on small screens
This revision was automatically updated to reflect the committed changes. Closed by commit R134:502b963bcc96: UpdatesPage: Fix icon sizing on small screens (authored by jbbgameich, committed by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18964?vs=51526&id=51544 REVISION DETAIL https://phabricator.kde.org/D18964 AFFECTED FILES discover/qml/UpdatesPage.qml To: jbbgameich, #discover_software_store, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18964: UpdatesPage: Fix icon sizing on small screens
ngraham added a comment. Sure, I'll do it this time. The documentation for using `arc` is really quite good though: https://community.kde.org/Infrastructure/Phabricator REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18964 To: jbbgameich, #discover_software_store, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18964: UpdatesPage: Fix icon sizing on small screens
jbbgameich added a comment. I'm sorry, I'm not yet used to the Phabricator workflow. My attempt to convert this revision into a proper arc diff I can land failed, since this was initially created by pasting `git diff` output. If possible, can you land the patch? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18964 To: jbbgameich, #discover_software_store, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18964: UpdatesPage: Fix icon sizing on small screens
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Got some updates and confirmed that this fixes the bug. Code looks sane. Please land on the `Plasma/5.15` branch and then merge to master. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18964 To: jbbgameich, #discover_software_store, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18964: UpdatesPage: Fix icon sizing on small screens
jbbgameich added a comment. Thanks, done. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18964 To: jbbgameich, #discover_software_store Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18964: UpdatesPage: Fix icon sizing on small screens
ngraham added a comment. Yep, see https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18964 To: jbbgameich, #discover_software_store Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18964: UpdatesPage: Fix icon sizing on small screens
jbbgameich added a comment. Yes, this looks like the same problem. Since the UpdatesPage width is being decreased when opening the "More information", it's the same effect as on a phone screen where the width is always that small. Can / should I somehow tag this patch so it marks the bug as resolved? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18964 To: jbbgameich, #discover_software_store Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18964: UpdatesPage: Fix icon sizing on small screens
ngraham added a comment. Can you confirm whether or not this also fixes https://bugs.kde.org/show_bug.cgi?id=404070? Can't test right now, I don't have any updates! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18964 To: jbbgameich, #discover_software_store Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18964: UpdatesPage: Fix icon sizing on small screens
jbbgameich created this revision. jbbgameich added a reviewer: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY On Small screens (e.g phones), not all list items have the same height, for example when a package has a long version string. Since the width of the icon was previously copied from the height, this resulted in inconsistent icon sizes. This patch sets the icon size to a constant value, which fixes the problem. TEST PLAN Icon sizes are consistent and still correctly sized REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18964 AFFECTED FILES discover/qml/UpdatesPage.qml To: jbbgameich, #discover_software_store Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
