D19019: Verify that model.AppPid is defined

2019-03-24 Thread Christoph Feck 
cfeck requested changes to this revision.
cfeck added a comment.
This revision now requires changes to proceed.


  It was suggested to change the model (C++ code? where?) instead.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19019

To: serhiyz, #plasma, davidedmundson, cfeck
Cc: cfeck, mart, broulik, hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D19019: Verify that model.AppPid is defined

2019-02-26 Thread Marco Martin 
mart added a comment.


  +1 for fixing the model instead (0 also for startup tasks?)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19019

To: serhiyz, #plasma, davidedmundson
Cc: mart, broulik, hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D19019: Verify that model.AppPid is defined

2019-02-14 Thread Kai Uwe Broulik 
broulik added a comment.


  Only actual windows have PIDs, the role isn't implemented for startup tasks 
or launchers iirc

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19019

To: serhiyz, #plasma, davidedmundson
Cc: broulik, hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19019: Verify that model.AppPid is defined

2019-02-14 Thread Eike Hein 
hein added a comment.


  Remote clients have no pid, but might be nicer to fix the model to return 0.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19019

To: serhiyz, #plasma, davidedmundson
Cc: hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19019: Verify that model.AppPid is defined

2019-02-14 Thread David Edmundson 
davidedmundson added a comment.


  In what situation is it undefined?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19019

To: serhiyz, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19019: Verify that model.AppPid is defined

2019-02-14 Thread Serhiy Zahoriya 
serhiyz created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
serhiyz requested review of this revision.

REVISION SUMMARY
  Verify that model.AppPid is defined to avoid error messages on every hover of 
an item in Task Manager.
  
  BUG: 396316

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19019

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

To: serhiyz
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart