D19176: [weather] envcan: Fix typo in lowercase icon lookup string

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:58e6cc6e119f: [weather] envcan: Fix typo in lowercase 
icon lookup string (authored by Zren).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19176?vs=52122=52485

REVISION DETAIL
  https://phabricator.kde.org/D19176

AFFECTED FILES
  dataengines/weather/ions/envcan/ion_envcan.cpp

To: Zren, #plasma, kossebau
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19176: [weather] envcan: Fix typo in lowercase icon lookup string

[Friedrich W. H. Kossebau]

kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  Thanks, untested by me, but seems correct by quick read.
  
  Yes, 5.12 => 5.14 => 5.15 => master might still make sense, given that Debian 
usage, how insane that even is.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19176

To: Zren, #plasma, kossebau
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19176: [weather] envcan: Fix typo in lowercase icon lookup string

[Chris Holland]

Zren created this revision.
Zren added reviewers: Plasma, kossebau.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  The capital `S` breaks the icon match.
  
  It was broken in Plasma 5.6 

 => Plasma 5.7 
,
 so I guess I'll merge 5.12 => 5.14 => 5.15 => master, assuming we still need 
to backport to 5.14 for Debian?  
  
https://github.com/KDE/plasma-workspace/blob/Plasma/5.12/dataengines/weather/ions/envcan/ion_envcan.cpp#L294
  
  Do I bother putting `FIXED-IN: 5.15.2` if there's no bug report?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19176

AFFECTED FILES
  dataengines/weather/ions/envcan/ion_envcan.cpp

To: Zren, #plasma, kossebau
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart