D19209: [sddm-kcm] Adjust Background label and button

2019-04-08 Thread Björn Feber 
GB_2 closed this revision.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19209

To: GB_2, #vdg, #plasma, filipf, ngraham
Cc: GB_2, abetts, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

2019-04-06 Thread Björn Feber 
GB_2 added a comment.


  I think I can leave it how it is now.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19209

To: GB_2, #vdg, #plasma, filipf, ngraham
Cc: GB_2, abetts, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

2019-04-04 Thread Björn Feber 
GB_2 commandeered this revision.
GB_2 edited reviewers, added: rooty; removed: GB_2.
GB_2 added a comment.


  Ok, thanks.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19209

To: GB_2, #vdg, #plasma, filipf, ngraham, rooty
Cc: GB_2, abetts, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

2019-04-04 Thread Filip Fila 
filipf updated this revision to Diff 55439.
filipf added a comment.


  attempt to allow for commandeering of the revision

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19209?vs=52256=55439

BRANCH
  arcpatch-D19209

REVISION DETAIL
  https://phabricator.kde.org/D19209

AFFECTED FILES
  src/ui/themeconfig.ui

To: rooty, #vdg, #plasma, filipf, ngraham, GB_2
Cc: GB_2, abetts, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

2019-04-04 Thread Filip Fila 
filipf added a comment.


  In D19209#443418 , @GB_2 wrote:
  
  > @rooty Can you please reopen this?
  
  
  He is participating in KDE for the time being. You should commandeer the 
revision.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19209

To: rooty, #vdg, #plasma, filipf, ngraham, GB_2
Cc: GB_2, abetts, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

2019-04-04 Thread Björn Feber 
GB_2 added a comment.


  @rooty Can you please reopen this?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19209

To: rooty, #vdg, #plasma, filipf, ngraham, GB_2
Cc: GB_2, abetts, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

2019-04-04 Thread Björn Feber 
GB_2 added a comment.


  Is this okay with a form layout?
  F6753594: Adjusted SDDM KCM Background Label and Button.png 

  If yes, I will take over this revision.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19209

To: rooty, #vdg, #plasma, filipf, ngraham
Cc: GB_2, abetts, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

2019-02-21 Thread Krešimir Čohar 
rooty updated this revision to Diff 52256.
rooty added a comment.


  Remove "Customize theme" heading

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19209?vs=52235=52256

BRANCH
  bckgr-label-padding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19209

AFFECTED FILES
  src/ui/themeconfig.ui

To: rooty, #vdg, #plasma, filipf, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

2019-02-21 Thread Andres Betts 
abetts added a comment.


  +1

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19209

To: rooty, #vdg, #plasma, filipf, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

2019-02-21 Thread Filip Fila 
filipf added a comment.


  In D19209#416946 , @rooty wrote:
  
  > Also, should we ditch the heading "Customize theme"? It doesn't seem 
necessary seeing as there's nothing to customize... aside from the wallpaper
  
  
  I'm also in favor of this, it's a bit misleading. Good job aligning things!

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19209

To: rooty, #vdg, #plasma, filipf, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

2019-02-21 Thread Nathaniel Graham 
ngraham added a comment.


  In D19209#416946 , @rooty wrote:
  
  > Also, should we ditch the heading "Customize theme"? It doesn't seem 
necessary seeing as there's nothing to customize... aside from the wallpaper
  
  
  Yes please!

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19209

To: rooty, #vdg, #plasma, filipf, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

2019-02-21 Thread Krešimir Čohar 
rooty added a comment.


  Also, should we ditch the heading "Customize theme"? It doesn't seem 
necessary seeing as there's nothing to customize... aside from the wallpaper

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19209

To: rooty, #vdg, #plasma, filipf, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

2019-02-21 Thread Krešimir Čohar 
rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch adjusts the "Background:" label (adds padding and changes its 
alignment) and button to align with the changes implemented in D19077 
. It also moves the background preview 
button to below its corresponding label.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  bckgr-label-padding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19209

AFFECTED FILES
  src/ui/themeconfig.ui

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart