D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Filip Fila 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5e905afb07e8: [TaskManager] Modernize and reorganize 
configuration settings (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19280?vs=52647=52652

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Björn Feber 
GB_2 added a comment.


  Now just update the screenshots.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  Indentation looks good! Looks great and works great for both regular and 
icons-only task managers, in both horizontal and vertical orientations.
  
  Shipit!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Eike Hein 
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  I'm OK with this, but I'd like @ngraham to verify consistency on the indent 
issue.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Björn Feber 
GB_2 added inline comments.

INLINE COMMENTS

> ngraham wrote in ConfigAppearance.qml:21
> Yes it is, there's a RowLayout in here.

I meant the QQC1 import, but it was removed just before I posted this comment :P

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> GB_2 wrote in ConfigAppearance.qml:21
> Import is not needed anymore.

Yes it is, there's a RowLayout in here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Björn Feber 
GB_2 added inline comments.

INLINE COMMENTS

> ConfigAppearance.qml:21
> +import QtQuick 2.0
> +import QtQuick.Controls 1.0 as QQC1
> +import QtQuick.Controls 2.5

Import is not needed anymore.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Filip Fila 
filipf updated this revision to Diff 52647.
filipf added a comment.


  Don't import QQC1 for ConfigAppearance.qml

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19280?vs=52646=52647

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Filip Fila 
filipf added a comment.


  In D19280#420401 , @filipf wrote:
  
  > rename "vertical" property to "plasmoidVertical" because it was interfering 
with QQC2's slider 
  >  "vertical" variable; use QQC2 slider
  
  
  Shoutout to @GB_2 for figuring out why the QQC2 slider didn't work. Hopefully 
everything is fine now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Filip Fila 
filipf updated this revision to Diff 52646.
filipf added a comment.


  rename "vertical" property to "plasmoidVertical" because it was interfering 
with QQC2's slider 
  "vertical" variable; use QQC2 slider

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19280?vs=52644=52646

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Filip Fila 
filipf updated this revision to Diff 52644.
filipf added a comment.


  use units.largeSpacing for indentation; remove redunant visible: vertical 
properties for children 
  of RowLayout

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19280?vs=52565=52644

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Björn Feber 
GB_2 added inline comments.

INLINE COMMENTS

> filipf wrote in ConfigBehavior.qml:69
> I tried `units.largeSpacing` first then realized it's not aligned with the 
> top text (not even with 1.0 scaling) so I did something like 
> `(units.largeSpacing - units.smallSpacing * 2)` which worked ok with 1.0 
> scaling but the higher the scaling factor the more the text shifted to the 
> right = it stopped being aligned with the top text. This bad code that's 
> present now worked well with all scaling preferences. I can just do 
> `units.largeSpacing` though if everyone is fine with that.

`units.largeSpacing` is correct and used in other places too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Filip Fila 
filipf added inline comments.

INLINE COMMENTS

> GB_2 wrote in ConfigBehavior.qml:69
> Should be `units.largeSpacing`

I tried `units.largeSpacing` first then realized it's not aligned with the top 
text (not even with 1.0 scaling) so I did something like `(units.largeSpacing - 
units.smallSpacing * 2)` which worked ok with 1.0 scaling but the higher the 
scaling factor the more the text shifted to the right = it stopped being 
aligned with the top text. This bad code that's present now worked well with 
all scaling preferences. I can just do `units.largeSpacing` though if everyone 
is fine with that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Björn Feber 
GB_2 added inline comments.

INLINE COMMENTS

> hein wrote in ConfigBehavior.qml:69
> Wait, 10x the checkbox width?

Should be `units.largeSpacing`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Eike Hein 
hein added inline comments.

INLINE COMMENTS

> ConfigBehavior.qml:69
> +Item {
> +width: Math.round(groupPopups.width * 10)
> +}

Wait, 10x the checkbox width?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-25 Thread Filip Fila 
filipf updated this revision to Diff 52565.
filipf added a comment.


  I forgot to hide the grouping and sorting options when using Icons-only

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19280?vs=52518=52565

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-25 Thread Filip Fila 
filipf updated this revision to Diff 52518.
filipf added a comment.


  try a better solution for the indentation (now works consistently with 
scaling)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19280?vs=52514=52518

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-25 Thread Filip Fila 
filipf updated this revision to Diff 52514.
filipf added a comment.


  fix typo in comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19280?vs=52513=52514

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-25 Thread Filip Fila 
filipf updated this revision to Diff 52513.
filipf added a comment.


  revert grouping settings order and indent the onlyGroupWhenFull option

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19280?vs=52491=52513

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-24 Thread Eike Hein 
hein added a comment.


  > [X] Open groups in popups
  > [X] Only when the Task Manager is full
  
  Reversing and not indenting these options breaks their dependent 
relationship. Please revert this to the original layout.
  
  Looks nice otherwise!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-24 Thread Filip Fila 
filipf added a comment.


  Thank you :)
  
  Does anyone from #plasma  maybe know 
why the QQC2 Slider fails to obey the "visible: vertical" setting? The 
variables have been changed in accordance with QQC2 and the slider does show up 
with no "visible:" status set, but simply won't work here.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2
Cc: GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-24 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks great and works great. Fantastic work!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-24 Thread Filip Fila 
filipf updated this revision to Diff 52491.
filipf added a comment.


  "Filters:" -> "Filter:", "Only when the Task Manager is full" -> "Group only 
when the Task 
  Manager is full" (I think it's better to be explicit), use 
"preferences-desktop-color" for 
  Appearance icon, "Highlight windows" -> "Highlight windows when hovering over 
tasks"

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19280?vs=52484=52491

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-24 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> ConfigAppearance.qml:56
> +id: highlightWindows
> +text: i18n("Highlight windows")
> +}

This would be a bit clearer if it said something more along the line of 
"Highlight windows when hovering over tasks"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-24 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> config.qml:27
> + name: i18n("Appearance")
> + icon: "preferences-desktop-plasma-theme"
> + source: "ConfigAppearance.qml"

Hmm, not sure this really fits, TBH. I kind of likes the colors-style icon you 
used in a previous version.

> GB_2 wrote in ConfigBehavior.qml:64
> "Task Manager" should be lowercase and a better text would be "Only group 
> when the task manager is full".
> I'd also switch the position with the above checkbox.

Uppercase is fine since it's a proper noun.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-24 Thread Björn Feber 
GB_2 added a comment.


  Almost perfect!

INLINE COMMENTS

> ConfigBehavior.qml:64
> +id: onlyGroupWhenFull
> +text: i18n("Only when the Task Manager is full")
> +enabled: groupingStrategy.currentIndex > 0 && groupPopups.checked

"Task Manager" should be lowercase and a better text would be "Only group when 
the task manager is full".
I'd also switch the position with the above checkbox.

> ConfigBehavior.qml:115
> +id: showOnlyCurrentScreen
> +Kirigami.FormData.label: i18n("Filters:")
> +text: i18n("Show only tasks from the current screen")

Better: "Filter:"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-24 Thread Filip Fila 
filipf added a comment.


  Much better, I agree! I've implemented all the changes.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-24 Thread Filip Fila 
filipf updated this revision to Diff 52484.
filipf added a comment.


  better categorization of settings

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19280?vs=52479=52484

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-24 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I love the idea of an Appearance/Behavior split. I think that really improves 
the approachability of the settings window. But I think it will require a bit 
of re-organization since with the current state of the patch, there are items 
on the Behavior page that are appearance-based, and vice versa.
  
  How about this for the breakdown?
  
Appearance

 General: [x] Show tooltips
  [ ] Highlight windows
  [x] Show progress and status information in task buttons
  [x] Mark applications that play audio

   Icon size: --o---
  SmallLarge

Maximum rows: [ 2 ]
  [x] Always arrange tasks in as many rows as columns
  
  
  
Behavior

   Group: [ By program name v ]
  [x] Open groups in popups
  [x] Only when the Task Manager is full

Sort: [ Manually v ]
  [x] Keep launchers separate

 On middle-click: [ Close Window or Group v ]
  [ ] Cycle through tasks with mouse wheel

 Filters: [ ] Show only tasks from the current screen
  [ ] Show only tasks from the current desktop
  [x] Show only tasks from the current activity
  [ ] Show only tasks that are minimized

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-24 Thread Filip Fila 
filipf updated this revision to Diff 52479.
filipf added a comment.


  use sentence-style capitalization for combobox entries

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19280?vs=52476=52479

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-24 Thread Krešimir Čohar 
rooty accepted this revision as: rooty.
rooty added a comment.
This revision is now accepted and ready to land.


  Works fine for me on neon, best wait for Nate's go-ahead but I'm convinced :D

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-24 Thread Filip Fila 
filipf updated this revision to Diff 52476.
filipf edited the test plan for this revision.
filipf added a comment.


  Use action verbs for "Sorting" and "Grouping"; extend "visible: vertical" 
property to all 
  revelant elements

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19280?vs=52465=52476

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-24 Thread Filip Fila 
filipf updated this revision to Diff 52465.
filipf added a comment.


  remove unneeded section breaks at the very beginning of the layout

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19280?vs=52461=52465

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-24 Thread Filip Fila 
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This patch ports most of the QQC1 elements into QQC2 and makes use of 
Kirigami.FormLayout.
  
  Due to an overwhelming  number of options originally being present, the patch 
also splits them up
  into "Appearance" and "Behavior" categories.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart