D19293: i18n: Add context to "Cannot fetch sources"

2019-02-24 Thread Alexander Potashev
aspotashev created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
aspotashev requested review of this revision.

TEST PLAN
  none

REPOSITORY
  R134 Discover Software Store

BRANCH
  i18n-context-fetch-source

REVISION DETAIL
  https://phabricator.kde.org/D19293

AFFECTED FILES
  libdiscover/backends/PackageKitBackend/PackageKitMessages.cpp

To: aspotashev
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19293: i18n: Add context to "Cannot fetch sources"

2019-02-24 Thread Aleix Pol Gonzalez
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Looks good to me, maybe it would make sense to include the context on the 
rest? Why is this one special?

REPOSITORY
  R134 Discover Software Store

BRANCH
  i18n-context-fetch-source

REVISION DETAIL
  https://phabricator.kde.org/D19293

To: aspotashev, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart


D19293: i18n: Add context to "Cannot fetch sources"

2019-02-25 Thread Alexander Potashev
aspotashev added a comment.


  This one is special because it's very unclear without context: one may think 
"sources" stands for source code, at least Ukrainian translation proves this 
theory. Other error messages are probably not ambiguous.

REPOSITORY
  R134 Discover Software Store

BRANCH
  i18n-context-fetch-source

REVISION DETAIL
  https://phabricator.kde.org/D19293

To: aspotashev, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart


D19293: i18n: Add context to "Cannot fetch sources"

2019-02-25 Thread Alexander Potashev
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:43f8d067aa10: i18n: Add context to "Cannot fetch 
sources" (authored by aspotashev).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19293?vs=52496&id=52525

REVISION DETAIL
  https://phabricator.kde.org/D19293

AFFECTED FILES
  libdiscover/backends/PackageKitBackend/PackageKitMessages.cpp

To: aspotashev, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart