D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19746 AFFECTED FILES applets/lock_logout/contents/ui/ConfigGeneral.qml To: filipf Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout
ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ConfigGeneral.qml:72
> +id: sleep
> +text: i18n("Suspend")
> +enabled: iconsPage.canSuspend && (checkedOptions > 1 || !checked)
The original was correct :)
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D19746
To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout
filipf updated this revision to Diff 53853. filipf added a comment. suspend -> sleep REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19746?vs=53852&id=53853 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19746 AFFECTED FILES applets/lock_logout/contents/ui/ConfigGeneral.qml To: filipf, #plasma, #vdg, ngraham Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout
filipf marked an inline comment as done. filipf added a comment. Forgot about that :) There's still strings to fix in the main qml file for this applet (lockout.qml). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19746 To: filipf, #plasma, #vdg, ngraham Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout
filipf updated this revision to Diff 53858. filipf added a comment. actually fix the "sleep" string REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19746?vs=53853&id=53858 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19746 AFFECTED FILES applets/lock_logout/contents/ui/ConfigGeneral.qml To: filipf, #plasma, #vdg, ngraham Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout
filipf added a comment. ^ Ignore that, I was working on an older template. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19746 To: filipf, #plasma, #vdg, ngraham Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout
This revision was automatically updated to reflect the committed changes. Closed by commit R120:cef563e560ac: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19746?vs=53858&id=53926 REVISION DETAIL https://phabricator.kde.org/D19746 AFFECTED FILES applets/lock_logout/contents/ui/ConfigGeneral.qml To: filipf, #plasma, #vdg, ngraham Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
