D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

2019-03-22 Thread Friedrich W. H. Kossebau 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:34387d450ab2: [Desktop Theme KCM] Normalize 
margin around background in previews (authored by kossebau).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19748?vs=53938=54545

REVISION DETAIL
  https://phabricator.kde.org/D19748

AFFECTED FILES
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml

To: kossebau, #plasma, #vdg, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

2019-03-20 Thread Friedrich W. H. Kossebau 
kossebau added a comment.


  In D19748#434289 , @kossebau wrote:
  
  > In D19748#432027 , @broulik 
wrote:
  >
  > > F6696238: Screenshot_20190316_121442.png 

  > >  Seems it does break things here (both with and without Qt scaling :/)
  >
  
  
  I could reproduce this now by accident while juggling with my patches. Turns 
out this is another case where D19743  will 
fix things, as this ensures the correct current margins are used.
  So would be great if someone could have a look at that one. And also means, 
this patch here is then only Plasma master/5.16 material...

REPOSITORY
  R119 Plasma Desktop

BRANCH
  normalizeplasmathemepreviewmargins

REVISION DETAIL
  https://phabricator.kde.org/D19748

To: kossebau, #plasma, #vdg, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

2019-03-19 Thread Friedrich W. H. Kossebau 
kossebau added a comment.


  In D19748#432027 , @broulik wrote:
  
  > F6696238: Screenshot_20190316_121442.png 

  >  Seems it does break things here (both with and without Qt scaling :/)
  
  
  @broulik Any chance you could retry soon, with caches cleaned before? For me 
any such misrenderings disappeared and have not come back since I cleaned the 
cache. Also would I have no explanation code-wise why that would happen (though 
also no idea how the caching works, ideally that would not happen at all).
  
  Also happy to have somebody else try this :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  normalizeplasmathemepreviewmargins

REVISION DETAIL
  https://phabricator.kde.org/D19748

To: kossebau, #plasma, #vdg, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

2019-03-16 Thread Friedrich W. H. Kossebau 
kossebau added a comment.


  In D19748#432027 , @broulik wrote:
  
  > Seems it does break things here (both with and without Qt scaling :/)
  
  
  Could you retry with cleaned Plasma cache? As discussed before, I saw this 
with openSUSE dark as well, but since it disappeared and all the time I messed 
around with fluffy themes, I have not seen any new breakage of that kind.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  normalizeplasmathemepreviewmargins

REVISION DETAIL
  https://phabricator.kde.org/D19748

To: kossebau, #plasma, #vdg, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

2019-03-16 Thread Kai Uwe Broulik 
broulik added a comment.


  F6696238: Screenshot_20190316_121442.png 

  Seems it does break things here (both with and without Qt scaling :/)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  normalizeplasmathemepreviewmargins

REVISION DETAIL
  https://phabricator.kde.org/D19748

To: kossebau, #plasma, #vdg, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

2019-03-16 Thread Nathaniel Graham 
ngraham added a comment.


  No objection!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  normalizeplasmathemepreviewmargins

REVISION DETAIL
  https://phabricator.kde.org/D19748

To: kossebau, #plasma, #vdg, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

2019-03-15 Thread Friedrich W. H. Kossebau 
kossebau added a comment.


  Personally I would consider this a bug fix and apply to 5.12. I always 
thought the openSUSE themes are broken just by their preview being so messy. 
It's a simple fix with no side-effects by what I can tell.
  What do you think?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  normalizeplasmathemepreviewmargins

REVISION DETAIL
  https://phabricator.kde.org/D19748

To: kossebau, #plasma, #vdg, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

2019-03-15 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Let's ship Plasma Bunny by default! /s

REPOSITORY
  R119 Plasma Desktop

BRANCH
  normalizeplasmathemepreviewmargins

REVISION DETAIL
  https://phabricator.kde.org/D19748

To: kossebau, #plasma, #vdg, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

2019-03-15 Thread Friedrich W. H. Kossebau 
kossebau updated this revision to Diff 53938.
kossebau added a comment.


  Clip the background to not overrun the item border and thus also the
  selection/highlight markup
  
  Hit & found thanks to fluffy themes :)
  F6692527: Screenshot_20190315_073305.png 


REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19748?vs=53856=53938

BRANCH
  normalizeplasmathemepreviewmargins

REVISION DETAIL
  https://phabricator.kde.org/D19748

AFFECTED FILES
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml

To: kossebau, #plasma, #vdg
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

2019-03-14 Thread Nathaniel Graham 
ngraham accepted this revision as: VDG.
ngraham added a comment.


  This visual change makes sense to me, +1.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19748

To: kossebau, #plasma, #vdg
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

2019-03-14 Thread Friedrich W. H. Kossebau 
kossebau added a comment.


  Seems the broken openSUSEdark display was due to cached rendered pixmaps, at 
least I can no longer reproduce it. So for completeness, and do celebrate the 
initial recovery of good old Fluffy Bunny theme, here another After (beware, 
can harm sensitive eyes):
  F6691045: Screenshot_20190314_141444.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19748

To: kossebau, #plasma, #vdg
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

2019-03-14 Thread Kai Uwe Broulik 
broulik added a comment.


  +1 Since there is no "proper" way I think this is fine and also looks a lot 
better than the previous Kraut und Rüben.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19748

To: kossebau, #plasma, #vdg
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

2019-03-13 Thread Friedrich W. H. Kossebau 
kossebau updated this revision to Diff 53856.
kossebau added a comment.


  On a second look, of course the normalized margins should be also used for
  the content shown in the widget

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19748?vs=53855=53856

BRANCH
  normalizeplasmathemepreviewmargins

REVISION DETAIL
  https://phabricator.kde.org/D19748

AFFECTED FILES
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml

To: kossebau, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

2019-03-13 Thread Friedrich W. H. Kossebau 
kossebau added a comment.


  The hack for "Air" was especially annoying as it fails for themes inheriting 
"Air" and reusing the widget background, like "Air openSUSE" 
  Before:
  F6690445: Screenshot_20190314_060226.png 

  After:
  F6690447: Screenshot_20190314_062422.png 

  Looks in average better IMHO, and makes things more comparaible, unless one 
is out to know the transparent margin size perhaps.
  Something still strange with "openSUSE dark", but that might be an issue with 
the theme itself.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19748

To: kossebau, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

2019-03-13 Thread Friedrich W. H. Kossebau 
kossebau created this revision.
kossebau added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Instead of a hard-coded hack for a single theme ("Air") to deal with themes
  with large margins, having a generic hack based on heuristics makes
  non-default themes look better in the preview.
  Not using "widgets/panel-background" for "Air" also results in a better
  preview for Air.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  normalizeplasmathemepreviewmargins

REVISION DETAIL
  https://phabricator.kde.org/D19748

AFFECTED FILES
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml

To: kossebau, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart