D19821: Fix breeze dialog background with Qt 5.12.2

[Krešimir Čohar]

rooty added a comment.


  In D19821#434410 , @fvogt wrote:
  
  > In D19821#434405 , @rooty wrote:
  >
  > > This wasn't supposed to land in Plasma 5.15 as well as master?
  >
  >
  > Plasma Framework is (in this case unfortunately) a Framework, so no stable 
branches.
  
  
  My bad!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Fabian Vogt]

fvogt added a comment.


  In D19821#434405 , @rooty wrote:
  
  > This wasn't supposed to land in Plasma 5.15 as well as master?
  
  
  Plasma Framework is (in this case unfortunately) a Framework, so no stable 
branches.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Krešimir Čohar]

rooty added a comment.


  This wasn't supposed to land in Plasma 5.15 as well as master?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Fabian Vogt]

fvogt added a comment.


  In D19821#434371 , @rikmills wrote:
  
  > I guess it is very likely, but all the same for the record I will request 
that this results in a 5.56.2 release of plasma-framework.
  
  
  I agree - as this touches binary files, applying a patch wouldn't work 
(unless using git apply).
  
  I just gave this diff a try again and could not find any place with broken 
SVG colors anymore.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:3aba8a7e10e5: Fix breeze dialog background with Qt 5.12.2 
(authored by fvogt).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19821?vs=54176=54319

REVISION DETAIL
  https://phabricator.kde.org/D19821

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svgz
  src/desktoptheme/breeze/translucent/dialogs/background.svgz
  src/desktoptheme/breeze/translucent/widgets/tooltip.svgz
  src/desktoptheme/breeze/widgets/tooltip.svgz

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Rik Mills]

rikmills added a comment.


  I guess it is very likely, but all the same for the record I will request 
that this results in a 5.56.2 release of plasma-framework.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Fabian Vogt]

fvogt added a comment.


  In D19821#434345 , @acooligan 
wrote:
  
  > Does this patch cover tooltips as shown in https://i.imgur.com/WrISfNg.png ?
  
  
  Yes.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Andrew Cooligan]

acooligan added a comment.


  Does this patch cover tooltips as shown in https://i.imgur.com/WrISfNg.png ?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Krešimir Čohar]

rooty accepted this revision.
rooty added a comment.
This revision is now accepted and ready to land.


  If it works for you ship it, I'm nowhere near a computer right now

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Fabian Vogt]

fvogt added a comment.


  Is anyone able to review this? If there's no review in 24h I'll merge it as 
it affects users severely and the fix is trivial.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma
Cc: filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Fabian Vogt]

fvogt updated this revision to Diff 54176.
fvogt added a comment.


  One more file.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19821?vs=54143=54176

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19821

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svgz
  src/desktoptheme/breeze/translucent/dialogs/background.svgz
  src/desktoptheme/breeze/translucent/widgets/tooltip.svgz
  src/desktoptheme/breeze/widgets/tooltip.svgz

To: fvogt, #plasma
Cc: falqueto, rooty, Zren, arojas, rikmills, asturmlechner, 
kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Fabian Vogt]

fvogt added a comment.


  There's a special case in `./src/desktoptheme/breeze/icons/audio.svgz` and 
`.../battery.svgz`: It has color scheme definitions both in a 

D19821: Fix breeze dialog background with Qt 5.12.2

[Fabian Vogt]

fvogt updated this revision to Diff 54143.
fvogt added a comment.


  Keep the style element, but assign id and type. Fix tooltip.svgz as well.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19821?vs=54076=54143

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19821

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svgz
  src/desktoptheme/breeze/translucent/dialogs/background.svgz
  src/desktoptheme/breeze/widgets/tooltip.svgz

To: fvogt, #plasma
Cc: rooty, Zren, arojas, rikmills, asturmlechner, kde-frameworks-devel, 
plasma-devel, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Krešimir Čohar]

rooty added a comment.


  In D19821#432780 , @Zren wrote:
  
  > Another option I believe is to keep the 

D19821: Fix breeze dialog background with Qt 5.12.2

[Chris Holland]

Zren added a comment.


  Another option I believe is to keep the 

D19821: Fix breeze dialog background with Qt 5.12.2

[Antonio Rojas]

arojas added a comment.


  Apparently tooltips need a fix too 
https://bbs.archlinux.org/viewtopic.php?pid=1837417#p1837417

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma
Cc: arojas, rikmills, asturmlechner, kde-frameworks-devel, plasma-devel, 
michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
fvogt requested review of this revision.

REVISION SUMMARY
  style elements without type="text/css" were ignored before, but now they act 
as
  if type was set. Remove the style element to restore the working behaviour.

TEST PLAN
  Installed new files on a system with Qt 5.12.2, wiped the SVG cache
  and it looks fine again.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19821

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svgz
  src/desktoptheme/breeze/translucent/dialogs/background.svgz

To: fvogt, #plasma
Cc: kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns