D19893: [KickerDash] Add missed argument in addFavorite

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:af28e245070e: [KickerDash] Add missed argument in 
addFavorite (authored by trmdi, committed by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19893?vs=54699=54745

REVISION DETAIL
  https://phabricator.kde.org/D19893

AFFECTED FILES
  applets/kicker/plugin/kastatsfavoritesmodel.cpp

To: trmdi, ngraham, hein, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19893: [KickerDash] Add missed argument in addFavorite

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Whoops! Nice catch.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19893

To: trmdi, ngraham, hein, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19893: [KickerDash] Add missed argument in addFavorite

[Tranter Madi]

trmdi added a comment.


  In D19893#437455 , @ngraham wrote:
  
  > Which bug are we fixing? A bit more context would be helpful. :)
  
  
  I can't find any one in the bug tracker, but you can easily reproduce it like 
I said at "Before" in the "Test Plan".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19893

To: trmdi, ngraham, hein, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart