D19959: Fixed issue causing changed signal to be called with false argument

2019-03-24 Thread Nathaniel Graham 
ngraham added a comment.


  @mlaurent you didn't commit with with correct authorship information in the 
git author field. :(

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19959

To: tigrang, mlaurent
Cc: ngraham, mlaurent, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19959: Fixed issue causing changed signal to be called with false argument

2019-03-23 Thread Laurent Montel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R123:ed3decc06e38:   Fixed issue causing changed signal to be 
called with false argument (authored by mlaurent).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19959?vs=54521&id=54594

REVISION DETAIL
  https://phabricator.kde.org/D19959

AFFECTED FILES
  src/advanceconfig.cpp

To: tigrang, mlaurent
Cc: mlaurent, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19959: Fixed issue causing changed signal to be called with false argument

2019-03-22 Thread Tigran Gabrielyan 
tigrang added a comment.


  I do not have commit access.
  
  Can you commit for me, please?
  
  Full Name: Tigran Gabrielyan
  Email: tigran...@gmail.com

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19959

To: tigrang, mlaurent
Cc: mlaurent, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19959: Fixed issue causing changed signal to be called with false argument

2019-03-22 Thread Laurent Montel 
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Good catch.
  it's a bug in clazy.
  
  Thanks
  Do you have an commit access ?
  or do you want that I commit for you ?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19959

To: tigrang, mlaurent
Cc: mlaurent, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19959: Fixed issue causing changed signal to be called with false argument

2019-03-21 Thread Tigran Gabrielyan 
tigrang created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tigrang requested review of this revision.

REVISION SUMMARY
  AdvanceConfig::changed signal is called with changed=false arguement when 
QGroupBox::clicked is called with checked=false causing the Apply button to 
remain disabled.
  

  
  BUG: 403366

TEST PLAN
  1. Open SDDM settings
  2. Enable auto-login, save and close.
  3. Open SDDM settings again
  4. Uncheck auto-login
  
  Apply button should now be enabled.
  Same steps for Relogin after quit checkbox.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19959

AFFECTED FILES
  src/advanceconfig.cpp

To: tigrang
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart