D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu

2019-06-21 Thread Méven Car
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a4e231e7b6c0: Display a shortcut to the kcm Energy 
Information from the battery applet… (authored by meven).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20533?vs=60208=60233

REVISION DETAIL
  https://phabricator.kde.org/D20533

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: meven, #plasma, ngraham, broulik, #vdg, filipf
Cc: abetts, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, mart


D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu

2019-06-21 Thread Méven Car
meven updated this revision to Diff 60208.
meven added a comment.


  Fix text

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20533?vs=56903=60208

BRANCH
  arcpatch-D20533_2

REVISION DETAIL
  https://phabricator.kde.org/D20533

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: meven, #plasma, ngraham, broulik, #vdg
Cc: abetts, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, mart


D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu

2019-06-21 Thread Nathaniel Graham
ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> meven wrote in batterymonitor.qml:142
> Thanks for pointing it out.

Not fixed yet. The text needs to be "Show Energy Information..."

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20533

To: meven, #plasma, ngraham, broulik, #vdg
Cc: abetts, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, mart


D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu

2019-04-24 Thread Méven Car
meven updated this revision to Diff 56903.
meven added a comment.


  Check the energy information is available before showing a link to it, don't 
show a link to it from the battery applet

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20533?vs=56602=56903

BRANCH
  arcpatch-D20533_1

REVISION DETAIL
  https://phabricator.kde.org/D20533

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: meven, #plasma, ngraham, broulik, #vdg
Cc: abetts, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, mart


D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu

2019-04-19 Thread Méven Car
meven marked an inline comment as done.
meven added inline comments.

INLINE COMMENTS

> ngraham wrote in batterymonitor.qml:142
> Generally we start menu items with action verbs. And in this case we don't 
> need ellipsis because no further input from the user is required as a part of 
> the action. See 
> https://hig.kde.org/style/writing/labels.html#using-ellipses-in-labels
> 
> So for this string, I would recommend "Show Energy Information"

Thanks for pointing it out.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20533

To: meven, #plasma, ngraham, broulik, #vdg
Cc: abetts, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, mart


D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu

2019-04-19 Thread Méven Car
meven updated this revision to Diff 56602.
meven added a comment.


  Start menu action with a verb

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20533?vs=56588=56602

BRANCH
  arcpatch-D20533

REVISION DETAIL
  https://phabricator.kde.org/D20533

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PowerManagementItem.qml
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: meven, #plasma, ngraham, broulik, #vdg
Cc: abetts, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, mart


D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu

2019-04-19 Thread Nathaniel Graham
ngraham added inline comments.

INLINE COMMENTS

> batterymonitor.qml:142
> +if (batterymonitor.kcmEnergyInformationAuthorized) {
> +plasmoid.setAction("energyinformationkcm", i18n(" 
> Information..."), "battery");
> +}

Generally we start menu items with action verbs. And in this case we don't need 
ellipsis because no further input from the user is required as a part of the 
action. See 
https://hig.kde.org/style/writing/labels.html#using-ellipses-in-labels

So for this string, I would recommend "Show Energy Information"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20533

To: meven, #plasma, ngraham, broulik, #vdg
Cc: abetts, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, mart


D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu

2019-04-19 Thread Méven Car
meven updated this revision to Diff 56588.
meven added a comment.


  Inverted checks

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20533?vs=56587=56588

BRANCH
  arcpatch-D20533_1

REVISION DETAIL
  https://phabricator.kde.org/D20533

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: meven, #plasma, ngraham, broulik, #vdg
Cc: abetts, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, mart