D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b8d753f4f00f: [Pager] Port settings window to 
QQC2+Kirigami FormLayout and improve UI (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20796?vs=56941&id=56989

REVISION DETAIL
  https://phabricator.kde.org/D20796

AFFECTED FILES
  applets/pager/package/contents/config/config.qml
  applets/pager/package/contents/ui/configGeneral.qml

To: ngraham, #vdg, #plasma, GB_2
Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

[Björn Feber]

GB_2 accepted this revision as: VDG, GB_2.
GB_2 added a comment.
This revision is now accepted and ready to land.


  Perfect.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  modernize-pager-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20796

To: ngraham, #vdg, #plasma, GB_2
Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

[Nathaniel Graham]

ngraham updated this revision to Diff 56941.
ngraham marked an inline comment as done.
ngraham added a comment.


  Re-arrange radio buttons so the default one is on top

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20796?vs=56926&id=56941

BRANCH
  modernize-pager-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20796

AFFECTED FILES
  applets/pager/package/contents/config/config.qml
  applets/pager/package/contents/ui/configGeneral.qml

To: ngraham, #vdg, #plasma
Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

[Björn Feber]

GB_2 added a comment.


  Looks good UI-wise.

INLINE COMMENTS

> configGeneral.qml:136
> +}
> +QtControls.RadioButton {
> +id: noTextRadio

Default radio buttons should be at the top.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20796

To: ngraham, #vdg, #plasma
Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

[Nathaniel Graham]

ngraham updated this revision to Diff 56926.
ngraham added a comment.


  Also correct category icon

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20796?vs=56925&id=56926

BRANCH
  modernize-pager-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20796

AFFECTED FILES
  applets/pager/package/contents/config/config.qml
  applets/pager/package/contents/ui/configGeneral.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

[Nathaniel Graham]

ngraham created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  - Port to QQC2+Kirigami FormLayout
  - Adjust some strings to be more natural
  - Fix some incorrect strings when being an Activity pager

TEST PLAN
  All features still work.
  
  Virtual Desktops: F6791456: Pager - Virtual Desktops.png 

  
  Activities: F6791466: Pager - Activity.png 

  #VDG , #Plasma 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  modernize-pager-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20796

AFFECTED FILES
  applets/pager/package/contents/ui/configGeneral.qml

To: ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart