D20810: Fix launcher URL comparison

2019-04-26 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b6b008bbf0ec: Fix launcher URL comparison (authored by 
broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20810?vs=56961=57017

REVISION DETAIL
  https://phabricator.kde.org/D20810

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

To: broulik, #plasma, hein, ngraham, mlaurent, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D20810: Fix launcher URL comparison

2019-04-25 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ContextMenu.qml:279
>  
> -enabled: visualParent && get(atm.LauncherUrlWithoutIcon) !== ""
> +enabled: visualParent && get(atm.LauncherUrlWithoutIcon) != ""
>  

how about `enabled: visualParent && get(atm.LauncherUrlWithoutIcon)`?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20810

To: broulik, #plasma, hein, ngraham, mlaurent, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D20810: Fix launcher URL comparison

2019-04-25 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, hein, ngraham, mlaurent.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Launcher URL is a `QUrl` which doesn't strictly map empty `string`.

TEST PLAN
  Pin to task bar and start new instance is correctly disabled now if no 
launcher url could be determined
  Yet another regression caused by 6e36de2e1e92743751ddd5b735cdfe9b2e95e5e2 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20810

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

To: broulik, #plasma, hein, ngraham, mlaurent
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart