D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b6d785370d53: Add the Show Desktop applet (moved from 
kdeplasma-addons) (authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20818?vs=57040&id=57057

REVISION DETAIL
  https://phabricator.kde.org/D20818

AFFECTED FILES
  applets/CMakeLists.txt
  applets/minimizeall/CMakeLists.txt
  applets/minimizeall/Messages.sh
  applets/minimizeall/package/contents/config/main.xml
  applets/minimizeall/package/contents/ui/main.qml
  applets/minimizeall/package/metadata.desktop
  applets/showdesktop/CMakeLists.txt
  applets/showdesktop/Messages.sh
  applets/showdesktop/package/contents/config/main.xml
  applets/showdesktop/package/contents/ui/main.qml
  applets/showdesktop/package/metadata.desktop
  applets/showdesktop/plugin/qmldir
  applets/showdesktop/plugin/showdesktop.cpp
  applets/showdesktop/plugin/showdesktop.h
  applets/showdesktop/plugin/showdesktopplugin.cpp
  applets/showdesktop/plugin/showdesktopplugin.h

To: GB_2, #plasma, #vdg, ngraham, apol
Cc: apol, ltoscano, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

[Björn Feber]

GB_2 updated this revision to Diff 57040.
GB_2 added a comment.


  Move Minimize All too, so there is an alternative

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20818?vs=56973&id=57040

BRANCH
  arcpatch-D20818

REVISION DETAIL
  https://phabricator.kde.org/D20818

AFFECTED FILES
  applets/CMakeLists.txt
  applets/minimizeall/CMakeLists.txt
  applets/minimizeall/Messages.sh
  applets/minimizeall/package/contents/config/main.xml
  applets/minimizeall/package/contents/ui/main.qml
  applets/minimizeall/package/metadata.desktop
  applets/showdesktop/CMakeLists.txt
  applets/showdesktop/Messages.sh
  applets/showdesktop/package/contents/config/main.xml
  applets/showdesktop/package/contents/ui/main.qml
  applets/showdesktop/package/metadata.desktop
  applets/showdesktop/plugin/qmldir
  applets/showdesktop/plugin/showdesktop.cpp
  applets/showdesktop/plugin/showdesktop.h
  applets/showdesktop/plugin/showdesktopplugin.cpp
  applets/showdesktop/plugin/showdesktopplugin.h

To: GB_2, #plasma, #vdg, ngraham, apol
Cc: apol, ltoscano, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

[Björn Feber]

GB_2 added a comment.


  Does that mean I can land it?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  move-showdesktop-applet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20818

To: GB_2, #plasma, #vdg, ngraham, apol
Cc: apol, ltoscano, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

[Luigi Toscano]

ltoscano added a comment.


  Thanks, I will keep an eye on the review.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  move-showdesktop-applet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20818

To: GB_2, #plasma, #vdg, ngraham, apol
Cc: apol, ltoscano, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

[Aleix Pol Gonzalez]

apol added subscribers: ltoscano, apol.
apol accepted this revision.
apol added a comment.


  Looks good to me. Will have to move the (few) translations with it. @ltoscano

REPOSITORY
  R119 Plasma Desktop

BRANCH
  move-showdesktop-applet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20818

To: GB_2, #plasma, #vdg, ngraham, apol
Cc: apol, ltoscano, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice. Please wait for a #plasma  
review too. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  move-showdesktop-applet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20818

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart