D20851: [Pager] Improve label legibility

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d09d4d52e161: [Pager] Improve label legibility (authored 
by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20851?vs=57220=57258

REVISION DETAIL
  https://phabricator.kde.org/D20851

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, hein
Cc: filipf, abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Nathaniel Graham]

ngraham updated this revision to Diff 57220.
ngraham added a comment.


  Revert unnecessary change

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20851?vs=57219=57220

BRANCH
  improve-pager-label-legibility (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20851

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma
Cc: filipf, abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Nathaniel Graham]

ngraham updated this revision to Diff 57219.
ngraham added a comment.


  Yeah it's way better without any visual changes except just moving the label 
to the top

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20851?vs=57063=57219

BRANCH
  improve-pager-label-legibility (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20851

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma
Cc: filipf, abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Noah Davis]

ndavis added a comment.


  In D20851#456931 , @ngraham wrote:
  
  > [...] In the first screenshot you can see that the number "1" is actually 
almost invisible. I'm open to suggestions for alternative ways to improve this.
  
  
  Yes, but this is because the text is under the blue highlight. I bet if the 
text was on top, then it would be much easier to read.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20851

To: ngraham, #vdg, #plasma
Cc: filipf, abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Filip Fila]

filipf added a comment.


  An outline could work, but maybe not at 100% opacity.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20851

To: ngraham, #vdg, #plasma
Cc: filipf, abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Andres Betts]

abetts added a comment.


  In D20851#456936 , @ngraham wrote:
  
  > In D20851#456932 , @abetts wrote:
  >
  > > I agree with this too. Do you think it would be too weird of other 
methods are used? For example:
  > >
  > > - Use a more legible font that is independent from system font
  > > - Use current system font 1 or 2 points bigger
  >
  >
  > I don't think those would help. A part of the problem is that the label 
isn't on top; other things are on top of it. Just moving it to the top would 
help, The other part of the problem is that we need some way to ensure that the 
text has contrast with its background. It's a variant of the exact same problem 
we always have when we have text or icons floating on top of an arbitrary 
background. Every time we encounter this, the only feasible solution we have 
ever found is to give the text a background or a shadow.
  
  
  Can we try a non-blurred shadow instead? One that is offset by 1 px? that 
might help too. I think when we use blurred, it gets messy at those sizes.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20851

To: ngraham, #vdg, #plasma
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Nathaniel Graham]

ngraham added a comment.


  In D20851#456932 , @abetts wrote:
  
  > I agree with this too. Do you think it would be too weird of other methods 
are used? For example:
  >
  > - Use a more legible font that is independent from system font
  > - Use current system font 1 or 2 points bigger
  
  
  I don't think those would help. A part of the problem is that the label isn't 
on top; other things are on top of it. Just moving it to the top would help, 
The other part of the problem is that we need some way to ensure that the text 
has contrast with its background. It's a variant of the exact same problem we 
always have when we have text or icons floating on top of an arbitrary 
background. Every time we encounter this, the only feasible solution we have 
ever found is to give the text a background or a shadow.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20851

To: ngraham, #vdg, #plasma
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Andres Betts]

abetts added a comment.


  In D20851#456931 , @ngraham wrote:
  
  > Well, I find it almost impossible to read the text with the status quo 
version when there are a bunch of window outlines. In the first screenshot you 
can see that the number "1" is actually almost invisible. I'm open to 
suggestions for alternative ways to improve this.
  
  
  I agree with this too. Do you think it would be too weird of other methods 
are used? For example:
  
  - Use a more legible font that is independent from system font
  - Use current system font 1 or 2 points bigger

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20851

To: ngraham, #vdg, #plasma
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Nathaniel Graham]

ngraham added a comment.


  Well, I find it almost impossible to read the text with the status quo 
version when there are a bunch of window outlines. In the first screenshot you 
can see that the number "1" is actually almost invisible. I'm open to 
suggestions for alternative ways to improve this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20851

To: ngraham, #vdg, #plasma
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Andres Betts]

abetts added a comment.


  In D20851#456903 , @ndavis wrote:
  
  > To me, the white text with the shadows doesn't really improve legibility 
and just looks "off". For some reason, shadow behind small text messes with my 
eyes and makes it harder to focus on the actual text.
  
  
  I agree.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20851

To: ngraham, #vdg, #plasma
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Noah Davis]

ndavis added a comment.


  To me, the white text with the shadows doesn't really improve legibility and 
just looks "off"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20851

To: ngraham, #vdg, #plasma
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently, when displaying pager labels (either number or name), text 
legibility is
  often poor or even non-existent, because the label is drawn below things that 
can
  and frequently do obscure it.
  
  This patch puts the label on top and gives it a drop shadow so it's always 
legible.

TEST PLAN
  Before, displaying VD/Activity number: F6795368: Before, numbers.png 

  
  After, displaying VD/Activity number: F6795362: After, numbers.png 

  
  Before, displaying VD/Activity name: F6795367: Before, names.png 

  
  After, displaying VD/Activity name: F6795363: After, names.png 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-pager-label-legibility (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20851

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart