D21341: Call KRunner KRunner

[Marco Martin]

mart added a comment.


  This was a terrible decision.
  KRunner is the worst jargon one can imagine and shouldn't be anywhere in user 
facing UI

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21341

To: ngraham, #vdg, #plasma, ndavis
Cc: mart, abetts, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra

D21341: Call KRunner KRunner

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21341

To: ngraham, #vdg, #plasma, ndavis
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21341: Call KRunner KRunner

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:98b53a3667f2: Call KRunner KRunner (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21341?vs=58499=58501

REVISION DETAIL
  https://phabricator.kde.org/D21341

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp
  krunner/view.cpp
  lookandfeel/contents/runcommand/RunCommand.qml

To: ngraham, #vdg, #plasma, ndavis
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21341: Call KRunner KRunner

[Nathaniel Graham]

ngraham updated this revision to Diff 58499.
ngraham added a comment.


  Found one more

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21341?vs=58472=58499

BRANCH
  call-krunner-krunner (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21341

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp
  krunner/view.cpp
  lookandfeel/contents/runcommand/RunCommand.qml

To: ngraham, #vdg, #plasma, ndavis
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21341: Call KRunner KRunner

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Makes sense to me. "Run command" is far too vague. The first time I saw it, I 
thought it would let me run a command or bash script instead of opening KRunner.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  call-krunner-krunner (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21341

To: ngraham, #vdg, #plasma, ndavis
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21341: Call KRunner KRunner

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  We are currentlly very inconsistent how we refer to KRunner, impairing 
comprehensibility
  among both expert users (who know it as "KRunner") and novice users (for whom 
"Run
  Command" has a literal and somewhat scary meaning).
  
  This patch is a part of T10966: Unify how we refer to KRunner 
 and standardizes on "Show KRunner", 
helping to turn
  KRunner into a user-visible brand name like Apple's Spotlight.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  call-krunner-krunner (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21341

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp
  krunner/view.cpp

To: ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart