D21471: [Notifications] Remove space between pause/stop and details button

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21471

To: broulik, #plasma, #vdg, hein, filipf
Cc: abetts, felixernst, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21471: [Notifications] Remove space between pause/stop and details button

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:745c60a7766c: [Notifications] Remove space between 
pause/stop and details button (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21471?vs=58812=58836

REVISION DETAIL
  https://phabricator.kde.org/D21471

AFFECTED FILES
  applets/notifications/package/contents/ui/JobItem.qml

To: broulik, #plasma, #vdg, hein, filipf
Cc: felixernst, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21471: [Notifications] Remove space between pause/stop and details button

[Felix Ernst]

felixernst added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21471

To: broulik, #plasma, #vdg, hein, filipf
Cc: felixernst, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21471: [Notifications] Remove space between pause/stop and details button

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  Obviously looks better to me since there is alignment.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21471

To: broulik, #plasma, #vdg, hein, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21471: [Notifications] Remove space between pause/stop and details button

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This was meant to provide some separation but since the arrow icon has so 
much padding around it anyway and more importantly, it breaks alignment in the 
list, remove it.

TEST PLAN
  Before
  F6857677: Screenshot_20190529_091333.png 

  After
  F6857678: Screenshot_20190529_091405.png 

  --ocd
  Note how the stop icon (square) is aligned with the configure icon now
  After in the popu also looks fine
  F6857683: Screenshot_20190529_091758.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21471

AFFECTED FILES
  applets/notifications/package/contents/ui/JobItem.qml

To: broulik, #plasma, #vdg, hein
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart