D21610: Redesign Advanced tab

2019-06-06 Thread Filip Fila 
This revision was automatically updated to reflect the committed changes.
Closed by commit R123:e020446f7019: Redesign Advanced tab (authored by filipf).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21610?vs=59282=59305

REVISION DETAIL
  https://phabricator.kde.org/D21610

AFFECTED FILES
  src/advanceconfig.cpp
  src/ui/advanceconfig.ui

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21610: Redesign Advanced tab

2019-06-06 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Shipit! Master only, obviously

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  redesign-sddm-advanced-tab (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21610: Redesign Advanced tab

2019-06-06 Thread Filip Fila 
filipf updated this revision to Diff 59282.
filipf added a comment.


  improve string "Relogin after quit"

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21610?vs=59280=59282

BRANCH
  redesign-sddm-advanced-tab (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21610

AFFECTED FILES
  src/advanceconfig.cpp
  src/ui/advanceconfig.ui

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21610: Redesign Advanced tab

2019-06-06 Thread Filip Fila 
filipf added a comment.


  In D21610#475386 , @ngraham wrote:
  
  > In D21610#475385 , @filipf wrote:
  >
  > > My suggestion is to rename it to "Log in again after logging off"
  >
  >
  > Much better! How about "Log in again after immediately after logging off" 
to emphasize how instant it is? Or even "After logging off, immediately log in 
again".
  
  
  Nice, I'll do option no.1 because the HIG tells us to start off checkbox 
labels with an action verb.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21610: Redesign Advanced tab

2019-06-06 Thread Nathaniel Graham 
ngraham added a comment.


  In D21610#475385 , @filipf wrote:
  
  > My suggestion is to rename it to "Log in again after logging off"
  
  
  Much better! How about "Log in again after immediately after logging off" to 
emphasize how instant it is? Or even "After logging off, immediately log in 
again".

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21610: Redesign Advanced tab

2019-06-06 Thread Filip Fila 
filipf added a comment.


  In D21610#475382 , @ngraham wrote:
  
  > Much better, thanks! Works now.
  >
  > One final thing, maybe: can we re-word "Relogin after quit"? I admit I have 
no idea what it even does! It's also got an English error ("relogin" isn't a 
word) and it has no tooltip to explain what it does. Needs a bit of loving.
  
  
  I had no idea what it meant either lol. Then I thought about it a bit and 
assumed it means that when you have autologin on and you log off it just logs 
you back in. Which tests seem to confirm.
  
  My suggestion is to rename it to "Log in again after logging off"

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21610: Redesign Advanced tab

2019-06-06 Thread Nathaniel Graham 
ngraham added a comment.


  Much better, thanks! Works now.
  
  One final thing, maybe: can we re-word "Relogin after quit"? I admit I have 
no idea what it even does! It's also got an English error ("relogin" isn't a 
word) and it has no tooltip to explain what it does. Needs a bit of loving.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21610: Redesign Advanced tab

2019-06-06 Thread Filip Fila 
filipf updated this revision to Diff 59280.
filipf added a comment.


  use toggled instead of clicked

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21610?vs=59232=59280

BRANCH
  redesign-sddm-advanced-tab (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21610

AFFECTED FILES
  src/advanceconfig.cpp
  src/ui/advanceconfig.ui

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21610: Redesign Advanced tab

2019-06-06 Thread Nathaniel Graham 
ngraham added a comment.


  Ah you're right, that's a pre-existing issue. However it does get worse with 
this redesign since the Advanced page is now much more compact. Oh well.
  
  I've found one new issue: when auto-login is enabled and you go to the 
Advanced page, its checkbox is checked but none of the related controls are 
un-disabled: F6874337: Screenshot_20190606_071356.png 

  
  When you toggle it off and on again, they do get enabled as expected. An 
inline comment explains why:

INLINE COMMENTS

> advanceconfig.ui:247
> +   autoLogin
> +   clicked(bool)
> +   label_4

This and other subsequent connections are probably the problem. The signal is 
only getting passed along when the checkbox is actually clicked. But nothing is 
connected to its `checked()` signal, so it doesn't know to enable the controls 
when the checkbox starts out checked but is not explicitly clicked by the user.

You can probably change `clicked` to `checked`.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21610: Redesign Advanced tab

2019-06-06 Thread Filip Fila 
filipf added a comment.


  I believe that's due to the other tab. If you try to resize the Themes tab 
height-wise, you'll notice the scrollbar appears when the bottom buttons start 
disappearing. I'll investigate some more though.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21610: Redesign Advanced tab

2019-06-05 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Nice. Looks like this layout includes some empty whitespace on the bottom 
though. Open it in `kcmshell` and reduce the window height:
  
  F6873598: Screenshot_20190605_184827.png 


REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21610: Redesign Advanced tab

2019-06-05 Thread Filip Fila 
filipf updated this revision to Diff 59232.
filipf added a comment.


  update comment

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21610?vs=59231=59232

BRANCH
  redesign-sddm-advanced-tab (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21610

AFFECTED FILES
  src/advanceconfig.cpp
  src/ui/advanceconfig.ui

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21610: Redesign Advanced tab

2019-06-05 Thread Filip Fila 
filipf updated this revision to Diff 59231.
filipf added a comment.


  reduce height of vertical spacers

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21610?vs=59212=59231

BRANCH
  redesign-sddm-advanced-tab (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21610

AFFECTED FILES
  src/advanceconfig.cpp
  src/ui/advanceconfig.ui

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21610: Redesign Advanced tab

2019-06-05 Thread Andres Betts 
abetts added a comment.


  +1 on visuals

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21610: Redesign Advanced tab

2019-06-05 Thread Nathaniel Graham 
ngraham added a comment.


  In D21610#474842 , @filipf wrote:
  
  > The spacing between sections seems too big, I need to reduce it so that it 
matches the one in Kirigami's FormLayout.
  
  
  `QSpacerItem` works well for this, and you can customize the height so that 
it matches perfectly.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21610: Redesign Advanced tab

2019-06-05 Thread Filip Fila 
filipf planned changes to this revision.
filipf added a comment.


  The spacing between sections seems too big, I need to reduce it so that it 
matches the one in Kirigami's FormLayout.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21610: Redesign Advanced tab

2019-06-05 Thread Filip Fila 
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This patch redesigns and modernizes the Advanced tab of SDDM's KCM.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  redesign-sddm-advanced-tab (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21610

AFFECTED FILES
  src/advanceconfig.cpp
  src/ui/advanceconfig.ui

To: filipf
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart