D21614: [sddm-theme] Fix fontsize of virtual keyboard ToolButton

2019-06-05 Thread Filip Fila 
filipf added a comment.


  Thanks for the quick review everyone :)
  
  In D21614#474950 , @veqz wrote:
  
  > Looks better to me.
  >
  > Though wouldn't it be even better if it was even a point larger?
  
  
  They way we set it up now is that there is a hierarchy among font sizes and 
these buttons are the bottom had low priority. But 11pt would also be 
legitimate. From 5.17 the user should be able to have their own font size so 
we'll remove all this hardcoding.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21614

To: filipf, #vdg, hein, veqz, ngraham
Cc: ngraham, veqz, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21614: [sddm-theme] Fix fontsize of virtual keyboard ToolButton

2019-06-05 Thread Filip Fila 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:928201c550eb: [sddm-theme] Fix fontsize of virtual 
keyboard ToolButton (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21614?vs=59229=59230

REVISION DETAIL
  https://phabricator.kde.org/D21614

AFFECTED FILES
  sddm-theme/Main.qml

To: filipf, #vdg, hein, veqz, ngraham
Cc: ngraham, veqz, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21614: [sddm-theme] Fix fontsize of virtual keyboard ToolButton

2019-06-05 Thread Nathaniel Graham 
ngraham added a comment.


  In D21614#474950 , @veqz wrote:
  
  > Looks better to me.
  >
  > Though wouldn't it be even better if it was even a point larger?
  
  
  In fact I think most of our text looks better at 11 pt font, but that's a 
somewhat unpopular opinion. :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-virtualkeyboard-button-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21614

To: filipf, #vdg, hein, veqz, ngraham
Cc: ngraham, veqz, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21614: [sddm-theme] Fix fontsize of virtual keyboard ToolButton

2019-06-05 Thread Tore Havn 
veqz accepted this revision.
veqz added a comment.


  Looks better to me.
  
  Though wouldn't it be even better if it was even a point larger?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-virtualkeyboard-button-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21614

To: filipf, #vdg, hein, veqz
Cc: veqz, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21614: [sddm-theme] Fix fontsize of virtual keyboard ToolButton

2019-06-05 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  Whoops!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-virtualkeyboard-button-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21614

To: filipf, #vdg, hein, veqz, ngraham
Cc: ngraham, veqz, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21614: [sddm-theme] Fix fontsize of virtual keyboard ToolButton

2019-06-05 Thread Filip Fila 
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  When we updated the fonts in the sddm-theme, we bumped the default size from 
9pt to 10pt. We missed adding the relevant code to the virtual keyboard button 
so it remained 9pt. This patch brings it up to 10pt.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-virtualkeyboard-button-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21614

AFFECTED FILES
  sddm-theme/Main.qml

To: filipf
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart