D21667: Optionally display threads as if they were processes

[Topi Miettinen]

topimiettinen updated this revision to Diff 62153.
topimiettinen added a comment.


  untabify

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21667?vs=59398=62153

REVISION DETAIL
  https://phabricator.kde.org/D21667

AFFECTED FILES
  processcore/processes.cpp
  processcore/processes.h
  processcore/processes_atop_p.cpp
  processcore/processes_atop_p.h
  processcore/processes_base_p.h
  processcore/processes_dragonfly_p.cpp
  processcore/processes_freebsd_p.cpp
  processcore/processes_gnu_p.cpp
  processcore/processes_linux_p.cpp
  processcore/processes_local_p.h
  processcore/processes_netbsd_p.cpp
  processcore/processes_openbsd_p.cpp
  processcore/processes_remote_p.cpp
  processcore/processes_remote_p.h
  processcore/processes_solaris_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ProcessModel_p.h
  processui/ksysguardprocesslist.cpp

To: topimiettinen
Cc: anthonyfieroni, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21667: Optionally display threads as if they were processes

[Anthony Fieroni]

anthonyfieroni added a comment.


  Use spaces instead of tabs.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D21667

To: topimiettinen
Cc: anthonyfieroni, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21667: Optionally display threads as if they were processes

[Topi Miettinen]

topimiettinen added a comment.


  @davidedmundson If you are OK with the idea, could you please review this?

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D21667

To: topimiettinen
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21667: Optionally display threads as if they were processes

[Topi Miettinen]

topimiettinen added a comment.


  In D21667#477393 , @davidedmundson 
wrote:
  
  > What information would an end user gain from doing this?
  
  
  They get to see how programs uses threads, for example to help develop 
programs. It's probably not very useful for a non-developer, so I think making 
it a less visible menu option is better than for example explicit checkbox 
(like qps does). Here's a screenshot.
  F6881875: screenshot4.png 

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D21667

To: topimiettinen
Cc: davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21667: Optionally display threads as if they were processes

[David Edmundson]

davidedmundson added a comment.


  What information would an end user gain from doing this?

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D21667

To: topimiettinen
Cc: davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21667: Optionally display threads as if they were processes

[Topi Miettinen]

topimiettinen created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
topimiettinen requested review of this revision.

REVISION SUMMARY
  Display also threads as if they were processes. This is enabled with
  menu entry in PID column header.
  
  Signed-off-by: Topi Miettinen 

TEST PLAN
  None

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D21667

AFFECTED FILES
  processcore/processes.cpp
  processcore/processes.h
  processcore/processes_atop_p.cpp
  processcore/processes_atop_p.h
  processcore/processes_base_p.h
  processcore/processes_dragonfly_p.cpp
  processcore/processes_freebsd_p.cpp
  processcore/processes_gnu_p.cpp
  processcore/processes_linux_p.cpp
  processcore/processes_local_p.h
  processcore/processes_netbsd_p.cpp
  processcore/processes_openbsd_p.cpp
  processcore/processes_remote_p.cpp
  processcore/processes_remote_p.h
  processcore/processes_solaris_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ProcessModel_p.h
  processui/ksysguardprocesslist.cpp

To: topimiettinen
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart