D21668: WIP: Modernize and redesign the Night Color config window

2019-06-12 Thread Filip Fila 
filipf updated this revision to Diff 59688.
filipf added a comment.


  make the form layouts respond to window resizing

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21668?vs=59682=59688

BRANCH
  modernize-redesign-nightcolor-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21668

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/NumberField.qml
  kcms/nightcolor/package/contents/ui/TimeField.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: filipf, #vdg, ngraham, romangg, mart, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-12 Thread Nathaniel Graham 
ngraham added a comment.


  If I had to guess, it's because they're inside a column that doesn't span the 
full width of the page.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21668

To: filipf, #vdg, ngraham, romangg, mart, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-12 Thread Filip Fila 
filipf added a comment.


  In D21668#478822 , @davidedmundson 
wrote:
  
  > > getting there; all is aligned now, it's just that the content needs to be 
unstiffened
  >
  > What does that mean
  >
  > Please remove the WIP tag when things are ready for review.
  >
  > Generally this looks good to me, ++
  
  
  Form layouts should be horizontally centered and adjust to the window size. 
Right now they're painfully stuck on the left side and won't budge when 
resizing the window.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21668

To: filipf, #vdg, ngraham, romangg, mart, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-12 Thread David Edmundson 
davidedmundson added a comment.


  > getting there; all is aligned now, it's just that the content needs to be 
unstiffened
  
  What does that mean
  
  Please remove the WIP tag when things are ready for review.
  
  Generally this looks good to me, ++

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21668

To: filipf, #vdg, ngraham, romangg, mart, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-12 Thread Filip Fila 
filipf updated this revision to Diff 59682.
filipf added a comment.


  getting there; all is aligned now, it's just that the content needs to be 
unstiffened

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21668?vs=59404=59682

BRANCH
  modernize-redesign-nightcolor-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21668

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/NumberField.qml
  kcms/nightcolor/package/contents/ui/TimeField.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: filipf, #vdg, ngraham, romangg, mart, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-12 Thread Filip Fila 
filipf added a comment.


  OK, so everything works nice if the form layouts simply reside in main.qml as 
components. It's when we spawn them through loaders that we get binding loops 
and misalignment (even if twinFormLayouts is specified!). The loader is not 
specifying geometry to the layouts so everything gets messed up.
  
  Unless there is some way to address this, I can remove the extra .qml view 
files, i.e. merge them with main.qml. There's also the method of anchoring the 
source components in the loader left and right. Neither seem ideal.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21668

To: filipf, #vdg, ngraham, romangg, mart, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-09 Thread Filip Fila 
filipf added a comment.


  In D21668#476358 , @ngraham wrote:
  
  > Lovely! Can you align the bottom fields with the combobox above them?
  
  
  I tried to do that with twinFormLayouts but it creates binding loop problems 
that can even be traced back to FormLayout.qml.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21668

To: filipf, #vdg, ngraham, romangg, mart
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-08 Thread Nathaniel Graham 
ngraham added a comment.


  Lovely! Can you align the bottom fields with the combobox above them?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21668

To: filipf, #vdg, ngraham, romangg, mart
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-08 Thread Filip Fila 
filipf added inline comments.

INLINE COMMENTS

> main.qml:23
>  import org.kde.plasma.core 2.0 as PlasmaCore
> -import org.kde.plasma.extras 2.0 as PlasmaExtras
> +import org.kde.plasma.extras 2.0 as PlasmaExtras*/
> +import org.kde.kirigami 2.5 as Kirigami

Are these 3 imports needed? I couldn't figure out what they were doing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21668

To: filipf, #vdg, ngraham, romangg, mart
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-08 Thread Filip Fila 
filipf updated this revision to Diff 59404.
filipf added a comment.


  initial cleanup

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21668?vs=59403=59404

BRANCH
  modernize-redesign-nightcolor-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21668

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/NumberField.qml
  kcms/nightcolor/package/contents/ui/TimeField.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: filipf
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-08 Thread Filip Fila 
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Port to Kirigami FormLayout and QQC2.
  
  NOTE: There are some heavy binding loop errors about "implicitWidth" due to 
loading more FormLayouts into the main one. How to fix this?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  modernize-redesign-nightcolor-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21668

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/NumberField.qml
  kcms/nightcolor/package/contents/ui/TimeField.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: filipf
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart