D21745: show details examples in label itself instead of unexpected tooltip

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:a00df4badcd1: show details examples in label itself 
instead of unexpected tooltip (authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21745?vs=60565&id=60569#toc

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21745?vs=60565&id=60569

REVISION DETAIL
  https://phabricator.kde.org/D21745

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_base.cpp
  src/bugzillaintegration/reportassistantpages_base.h
  src/bugzillaintegration/ui/assistantpage_bugawareness.ui

To: sitter, ngraham, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21745: show details examples in label itself instead of unexpected tooltip

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1 shipit!

REPOSITORY
  R871 DrKonqi

BRANCH
  examples

REVISION DETAIL
  https://phabricator.kde.org/D21745

To: sitter, ngraham, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21745: show details examples in label itself instead of unexpected tooltip

[Harald Sitter]

sitter added a comment.


  F6930248: Screenshot_20190624_122741.png 


REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D21745

To: sitter, ngraham, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21745: show details examples in label itself instead of unexpected tooltip

[Harald Sitter]

sitter updated this revision to Diff 60565.
sitter added a comment.


  set smallest readable font as well. as seen in gwenview

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21745?vs=59586&id=60565

BRANCH
  examples

REVISION DETAIL
  https://phabricator.kde.org/D21745

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_base.cpp
  src/bugzillaintegration/reportassistantpages_base.h
  src/bugzillaintegration/ui/assistantpage_bugawareness.ui

To: sitter, ngraham, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21745: show details examples in label itself instead of unexpected tooltip

[Nathaniel Graham]

ngraham added a comment.


  If it used a smaller font, that might help. Gwenview does this, by way of 
illustration: F6883528: Screenshot_20190611_063851.png 


REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D21745

To: sitter, ngraham, #vdg
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21745: show details examples in label itself instead of unexpected tooltip

[Harald Sitter]

sitter added a comment.


  F6883269: Screenshot_20190611_114039.png 

  
  Doesn't look too hot. Suggestions welcome.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D21745

To: sitter, ngraham, #vdg
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21745: show details examples in label itself instead of unexpected tooltip

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  the previous UX wasn't good. the label contained a "link" highlight
  but that link was only a trigger to a tooltip. IOW it behaved more like
  a button than a link.
  
  instead of using a tooltip fully expand the examples into an indented label
  below the relevant checkbox.

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21745

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_base.cpp
  src/bugzillaintegration/reportassistantpages_base.h
  src/bugzillaintegration/ui/assistantpage_bugawareness.ui

To: sitter
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart