D21762: do not use long deprecated QString::toAscii
This revision was automatically updated to reflect the committed changes. Closed by commit R120:4cf47ad6818d: do not use long deprecated QString::toAscii (authored by sitter). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21762?vs=60564=60567 REVISION DETAIL https://phabricator.kde.org/D21762 AFFECTED FILES libtaskmanager/waylandtasksmodel.cpp To: sitter, hein, apol Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D21762: do not use long deprecated QString::toAscii
sitter updated this revision to Diff 60564. sitter added a comment. and update again because arcanist hates me REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21762?vs=60563=60564 BRANCH no-toascii REVISION DETAIL https://phabricator.kde.org/D21762 AFFECTED FILES libtaskmanager/waylandtasksmodel.cpp To: sitter, hein Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D21762: do not use long deprecated QString::toAscii
sitter updated this revision to Diff 60563. sitter added a comment. concat qstrings as suggested by @apol REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21762?vs=59639=60563 BRANCH no-toascii REVISION DETAIL https://phabricator.kde.org/D21762 AFFECTED FILES applets/activitybar/metadata.desktop applets/analog-clock/metadata.desktop applets/appmenu/package/metadata.desktop applets/calendar/package/metadata.desktop applets/clipboard/metadata.desktop applets/devicenotifier/package/metadata.desktop applets/devicenotifier/test-predicate-openinwindow.desktop applets/digital-clock/package/metadata.desktop applets/icon/package/metadata.desktop applets/lock_logout/metadata.desktop applets/notifications/package/metadata.desktop applets/systemmonitor/cpu/metadata.desktop applets/systemmonitor/diskactivity/metadata.desktop applets/systemmonitor/diskusage/metadata.desktop applets/systemmonitor/memory/metadata.desktop applets/systemmonitor/net/metadata.desktop applets/systemtray/container/package/metadata.desktop applets/systemtray/package/metadata.desktop appmenu/appmenu.desktop components/shellprivate/wallpaperplugin/wallpaperplugin.knsrc components/shellprivate/widgetexplorer/plasmoids.knsrc containmentactions/applauncher/plasma-containmentactions-applauncher.desktop containmentactions/contextmenu/plasma-containmentactions-contextmenu.desktop containmentactions/paste/plasma-containmentactions-paste.desktop containmentactions/switchactivity/plasma-containmentactions-switchactivity.desktop containmentactions/switchdesktop/plasma-containmentactions-switchdesktop.desktop containmentactions/switchwindow/plasma-containmentactions-switchwindow.desktop dataengines/activities/plasma-dataengine-activities.desktop dataengines/applicationjobs/plasma-dataengine-applicationjobs.desktop dataengines/apps/plasma-dataengine-apps.desktop dataengines/devicenotifications/plasma-dataengine-devicenotifications.desktop dataengines/dict/plasma-dataengine-dict.desktop dataengines/executable/plasma-dataengine-executable.desktop dataengines/filebrowser/plasma-dataengine-filebrowser.desktop dataengines/geolocation/plasma-geolocation-gps.desktop dataengines/geolocation/plasma-geolocation-ip.desktop dataengines/hotplug/plasma-dataengine-hotplug.desktop dataengines/keystate/plasma-dataengine-keystate.desktop dataengines/mouse/plasma-dataengine-mouse.desktop dataengines/notifications/plasma-dataengine-notifications.desktop dataengines/places/plasma-dataengine-places.desktop dataengines/share/packagestructure/plasma-packagestructure-share.desktop dataengines/share/plasma-dataengine-share.desktop dataengines/soliddevice/plasma-dataengine-soliddevice.desktop dataengines/statusnotifieritem/plasma-dataengine-statusnotifieritem.desktop dataengines/systemmonitor/plasma-dataengine-systemmonitor.desktop dataengines/time/plasma-dataengine-time.desktop dataengines/weather/ions/bbcukmet/ion-bbcukmet.desktop dataengines/weather/ions/noaa/ion-noaa.desktop dataengines/weather/plasma-dataengine-weather.desktop freespacenotifier/freespacenotifier.desktop freespacenotifier/freespacenotifier.notifyrc kcms/translations/kcm_translations.desktop kcms/translations/package/metadata.desktop kioslave/desktop/desktopnotifier.desktop klipper/klipper.desktop klipper/org.kde.klipper.desktop klipper/plasma-dataengine-clipboard.desktop ktimezoned/ktimezoned.desktop libcolorcorrect/kded/colorcorrectlocationupdater.desktop libtaskmanager/waylandtasksmodel.cpp phonon/platform_kde/phonon.notifyrc plasma-windowed/plasma-windowed.desktop runners/calculator/plasma-runner-calculator.desktop runners/places/plasma-runner-places.desktop shell/packageplugins/lookandfeel/plasma-packagestructure-lookandfeel.desktop systemmonitor/org.kde.systemmonitor.desktop To: sitter, hein Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D21762: do not use long deprecated QString::toAscii
apol added inline comments.
INLINE COMMENTS
> waylandtasksmodel.cpp:350
> // cross-process DND.
> -return QString("windowsystem/winid+" + uuid.toString().toAscii());
> +return QString("windowsystem/winid+" + uuid.toString().toLatin1());
> }
It's using weird API we shouldn't be using. It's creating a QString after all
so I'd do:
`return QStringLiteral("windowsystem/winid+") + uuid.toString();`
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D21762
To: sitter, hein
Cc: apol, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel,
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D21762: do not use long deprecated QString::toAscii
sitter created this revision. sitter added a reviewer: hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY use toLatin1 instead TEST PLAN builds REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.16 REVISION DETAIL https://phabricator.kde.org/D21762 AFFECTED FILES libtaskmanager/waylandtasksmodel.cpp To: sitter, hein Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
