D21872: Translate keyboard layouts in sddm

[David Edmundson]

davidedmundson added a comment.


  > So is this unnecessary, and the string should be translated somewhere over 
in FreeDesktop-land?
  
  The translations are done somewhere over in freedesktop-land, but someone 
still needs to load them.
  
  This does it in our theme. 
  My question is why is this better than doing it in the SDDM model so that it 
"just works" for all themes.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21872

To: McPain, ngraham, #plasma
Cc: pshinjo, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21872: Translate keyboard layouts in sddm

[Nathaniel Graham]

ngraham added a comment.


  So is this unnecessary, and the string should be translated somewhere over in 
FreeDesktop-land?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21872

To: McPain, ngraham, #plasma
Cc: pshinjo, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21872: Translate keyboard layouts in sddm

[Shinjo Park]

pshinjo added a comment.


  In D21872#481400 , @davidedmundson 
wrote:
  
  > > These translations doesn't belong to sddm
  >
  > why do they belong here and not SDDM?
  
  
  Searching for the translation catalog name shows that it is managed by 
freedesktop.org [1]. So neither KDE, nor SDDM.
  
  [1] https://github.com/freedesktop/xkeyboard-config/tree/master/po

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21872

To: McPain, ngraham, #plasma
Cc: pshinjo, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21872: Translate keyboard layouts in sddm

[David Edmundson]

davidedmundson added a comment.


  > These translations doesn't belong to sddm
  
  why do they belong here and not SDDM?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21872

To: McPain, ngraham, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21872: Translate keyboard layouts in sddm

[Oleg Solovyov]

McPain added a comment.


  In D21872#481213 , @ngraham wrote:
  
  > In D21872#481173 , @McPain wrote:
  >
  > > In D21872#481154 , 
@davidedmundson wrote:
  > >
  > > > It might be better to do it in
  > > >
  > > > XkbKeyboardBackend.cpp:184 in SDDM which is where the model comes from.
  > >
  > >
  > > I don't see any matching files in sddm
  >
  >
  > https://github.com/sddm/sddm/blob/develop/src/greeter/XcbKeyboardBackend.cpp
  
  
  thanks, but how should I do this?
  These translations doesn't belong to sddm

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21872

To: McPain, ngraham, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21872: Translate keyboard layouts in sddm

[Nathaniel Graham]

ngraham added a comment.


  In D21872#481173 , @McPain wrote:
  
  > In D21872#481154 , 
@davidedmundson wrote:
  >
  > > It might be better to do it in
  > >
  > > XkbKeyboardBackend.cpp:184 in SDDM which is where the model comes from.
  >
  >
  > I don't see any matching files in sddm
  
  
  https://github.com/sddm/sddm/blob/develop/src/greeter/XcbKeyboardBackend.cpp

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21872

To: McPain, ngraham
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21872: Translate keyboard layouts in sddm

[Oleg Solovyov]

McPain added a comment.


  In D21872#481154 , @davidedmundson 
wrote:
  
  > It might be better to do it in
  >
  > XkbKeyboardBackend.cpp:184 in SDDM which is where the model comes from.
  
  
  I don't see any matching files in sddm

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21872

To: McPain, ngraham
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21872: Translate keyboard layouts in sddm

[David Edmundson]

davidedmundson added a comment.


  It might be better to do it in
  
  XkbKeyboardBackend.cpp:184 in SDDM which is where the model comes from.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21872

To: McPain, ngraham
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21872: Translate keyboard layouts in sddm

[Oleg Solovyov]

McPain added a comment.


  F6901033: изображение.png F6901031: 
изображение.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21872

To: McPain, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21872: Translate keyboard layouts in sddm

[Oleg Solovyov]

McPain created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21872

AFFECTED FILES
  sddm-theme/KeyboardButton.qml

To: McPain
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart