D21935: [devicenotifier] Hide plasmoid if no device is available

[Nathaniel Graham]

ngraham added a subscriber: mart.
ngraham added a comment.


  @nicolasfella and I were discussing with someone else (@mart maybe?) redoing 
the System Tray configuration pages to collapse the General and Entries pages 
into a single list that displays Configure buttons for the configurable 
applets. That would help with the issue of configurability for 
hidden-by-default applets.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  hideit

REVISION DETAIL
  https://phabricator.kde.org/D21935

To: nicolasfella, #plasma, ngraham, broulik
Cc: mart, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D21935: [devicenotifier] Hide plasmoid if no device is available

[Kai Uwe Broulik]

broulik added a comment.


  Yes but you can only do that once it shows up because of a removable device 
then

REPOSITORY
  R120 Plasma Workspace

BRANCH
  hideit

REVISION DETAIL
  https://phabricator.kde.org/D21935

To: nicolasfella, #plasma, ngraham, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21935: [devicenotifier] Hide plasmoid if no device is available

[Nathaniel Graham]

ngraham added a comment.


  In D21935#482746 , @broulik wrote:
  
  > Not sure how useful it actually is to show non removable drives there. I 
only use that for testing, if ever. +/-0 from my side
  
  
  If you opt to make it show all drives, then it would have > 0 items and would 
show up, right?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  hideit

REVISION DETAIL
  https://phabricator.kde.org/D21935

To: nicolasfella, #plasma, ngraham, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21935: [devicenotifier] Hide plasmoid if no device is available

[Kai Uwe Broulik]

broulik added a comment.


  Not sure how useful it actually is to show non removable drives there. I only 
use that for testing, if ever. +/-0 from my side

REPOSITORY
  R120 Plasma Workspace

BRANCH
  hideit

REVISION DETAIL
  https://phabricator.kde.org/D21935

To: nicolasfella, #plasma, ngraham, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21935: [devicenotifier] Hide plasmoid if no device is available

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1, it's pointless to show something that can't be interacted with. I suppose 
technically you could right-click on it and configure it, but that seems like a 
niche use case (I doubt more than a dozen people even know the Devices Notifier 
plasmoid is configurable) and in any event you can always configure it when 
it's visible.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  hideit

REVISION DETAIL
  https://phabricator.kde.org/D21935

To: nicolasfella, #plasma, ngraham, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21935: [devicenotifier] Hide plasmoid if no device is available

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  When no device is present the plasmoid doesn't do anything interactive. It 
merely says that no device is available.
  By hiding it completely from the systray we reduce the visual clutter in the 
expanded system tray

REPOSITORY
  R120 Plasma Workspace

BRANCH
  hideit

REVISION DETAIL
  https://phabricator.kde.org/D21935

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/devicenotifier.qml

To: nicolasfella, #plasma, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart