D22005: Ensure url from KActivity resources are properly built

2020-01-25 Thread Méven Car 
meven abandoned this revision.
meven added a comment.


  After further check, my patch does not do much, just allowed me to discover 
bug about dolphin's recent folder list missing.
  
if (QDir::isAbsolutePath(resource)) {
resource = QUrl::fromLocalFile(resource).toString();
}
  
  Here `QDir::isAbsolutePath` will always be true because at line 312 ` | 
Url::file();`  we requested files only.
  
  Same is true for D24728 

INLINE COMMENTS

> backend.cpp:336
>  
>  if (!fileItem.isFile()) {
>  continue;

This prevents filemanager (or apps that opens dirs) to display their recent 
directories will fix.
Same goes in D24728 .

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22005

To: meven, #plasma, hein, broulik
Cc: ivan, meven, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D22005: Ensure url from KActivity resources are properly built

2019-10-17 Thread Méven Car 
meven updated this revision to Diff 68193.
meven added a comment.


  Avoid an unnecessary dereference

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22005?vs=68132&id=68193

BRANCH
  arcpatch-D22005

REVISION DETAIL
  https://phabricator.kde.org/D22005

AFFECTED FILES
  applets/taskmanager/plugin/backend.cpp

To: meven, #plasma, hein, broulik
Cc: ivan, meven, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D22005: Ensure url from KActivity resources are properly built

2019-10-17 Thread Ivan Čukić 
ivan added inline comments.

INLINE COMMENTS

> backend.cpp:322
>  while (actionCount < 5 && resultIt != results.end()) {
> -const QString resource = (*resultIt).resource();
> +QString resource = (*resultIt).resource();
> +if (QDir::isAbsolutePath(resource)) {

`resultIt->resource()` (when you are at it :) )

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22005

To: meven, #plasma, hein, broulik
Cc: ivan, meven, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D22005: Ensure url from KActivity resources are properly built

2019-10-17 Thread Méven Car 
meven updated this revision to Diff 68132.
meven added a comment.


  amend commit message

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22005?vs=68127&id=68132

BRANCH
  arcpatch-D22005

REVISION DETAIL
  https://phabricator.kde.org/D22005

AFFECTED FILES
  applets/taskmanager/plugin/backend.cpp

To: meven, #plasma, hein, broulik
Cc: meven, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart