D22028: Improve QWidget KCM and QML KCM consistency

2019-06-25 Thread Nathaniel Graham 
ngraham added a comment.


  Gotcha, thanks!

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D22028

To: meven, mart, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22028: Improve QWidget KCM and QML KCM consistency

2019-06-25 Thread Méven Car 
meven added a comment.


  In D22028#486409 , @ngraham wrote:
  
  > Could this be backported to the stable branch? It's a relative 
straightforward bugfix.
  
  
  Unfortunately no, it would cause a bug without the D20598 
 diff that added a title to the 
kinfocenter, causing the need here to remove the titles for QML KCM.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D22028

To: meven, mart, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22028: Improve QWidget KCM and QML KCM consistency

2019-06-25 Thread Nathaniel Graham 
ngraham added a comment.


  Could this be backported to the stable branch? It's a relative 
straightforward bugfix.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D22028

To: meven, mart, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22028: Improve QWidget KCM and QML KCM consistency

2019-06-24 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R102:4d5321648e9a: Improve QWidget KCM and QML KCM consistency 
(authored by meven).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22028?vs=60485=60619

REVISION DETAIL
  https://phabricator.kde.org/D22028

AFFECTED FILES
  kcmcontainer.cpp

To: meven, mart, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22028: Improve QWidget KCM and QML KCM consistency

2019-06-23 Thread Méven Car 
meven updated this revision to Diff 60485.
meven added a comment.


  Remove changes that will go to another review

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22028?vs=60484=60485

BRANCH
  fix-title-qml

REVISION DETAIL
  https://phabricator.kde.org/D22028

AFFECTED FILES
  kcmcontainer.cpp

To: meven, mart, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22028: Improve QWidget KCM and QML KCM consistency

2019-06-23 Thread Méven Car 
meven updated this revision to Diff 60484.
meven added a comment.


  Adjust font size

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22028?vs=60446=60484

BRANCH
  fix-title-qml

REVISION DETAIL
  https://phabricator.kde.org/D22028

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml
  kcmcontainer.cpp

To: meven, mart, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22028: Improve QWidget KCM and QML KCM consistency

2019-06-23 Thread Nathaniel Graham 
ngraham added a comment.


  Close! But the title sizes still appear to differ:
  
  F6927140: The bug-2019-06-23_13.03.08.webm 


REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D22028

To: meven, mart, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22028: Improve QWidget KCM and QML KCM consistency

2019-06-23 Thread Méven Car 
meven updated this revision to Diff 60446.
meven added a comment.


  Remove lines that shouldn't have been included

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22028?vs=60442=60446

BRANCH
  fix-title-qml

REVISION DETAIL
  https://phabricator.kde.org/D22028

AFFECTED FILES
  kcmcontainer.cpp

To: meven, mart, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22028: Improve QWidget KCM and QML KCM consistency

2019-06-23 Thread Méven Car 
meven created this revision.
meven added reviewers: mart, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  - Set QWidget KCMs title font size to the same one as QML ones
  - Add content margin to QWidget KCMs to match QML ones
  - Only display own KCM title in QML case

REPOSITORY
  R102 KInfoCenter

BRANCH
  fix-title-qml

REVISION DETAIL
  https://phabricator.kde.org/D22028

AFFECTED FILES
  Modules/fileindexermonitor/kcm.cpp
  kcmcontainer.cpp

To: meven, mart, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart