D22060: [Task Manager] Prefer PID match even when desktop entry doesn't match

2019-06-24 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:4a6a518a8b4c: [Task Manager] Prefer PID match even when 
desktop entry doesn't match (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22060?vs=60541&id=60560

REVISION DETAIL
  https://phabricator.kde.org/D22060

AFFECTED FILES
  applets/taskmanager/package/contents/ui/main.qml

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22060: [Task Manager] Prefer PID match even when desktop entry doesn't match

2019-06-23 Thread Kai Uwe Broulik
broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When an application got renamed by flatpak-builder without knowing it, it 
will still send its original value as desktop-entry breaking the mapping. If 
the PID of the service matches the window owner's PID imho it's fine to assume 
it's a match.

TEST PLAN
  5.16?
  
  - My spotify snap has media controls in its context menu and tooltip now
  - p-b-i (where the host binary doesn't match the browser window) still works 
for both Chrome and Firefix
  - VLC player still works

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22060

AFFECTED FILES
  applets/taskmanager/package/contents/ui/main.qml

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart