D22068: Send downloads when downloads plugin is loaded
broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We call `sendDownloads()` immediately when connecting to the port which looks racy. Instead, have the plugin tell the extension to send all downloads once it is loaded and ready to accept input. Kept the old call for compat which shouldn't hurt... TEST PLAN Started a download, reloaded the extension, reliably got a download created again REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D22068 AFFECTED FILES extension/extension.js host/downloadplugin.cpp host/downloadplugin.h To: broulik, #plasma, fvogt Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22068: Send downloads when downloads plugin is loaded
broulik added a comment. Or maybe I should remove the old code since the change to "update existing job when being signalled a creation" was only added in May REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D22068 To: broulik, #plasma, fvogt Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22068: Send downloads when downloads plugin is loaded
This revision was automatically updated to reflect the committed changes. Closed by commit R856:76d4b765f4f1: Send downloads when downloads plugin is loaded (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22068?vs=60557&id=60984 REVISION DETAIL https://phabricator.kde.org/D22068 AFFECTED FILES extension/extension.js host/downloadplugin.cpp host/downloadplugin.h To: broulik, #plasma, fvogt Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
