D22075: [Notifications] Swap configure and clear buttons in full representation header

2019-08-01 Thread Nathaniel Graham
ngraham added a comment.


  In retrospect, while this makes it consistent with what's below it, it's now 
inconsistent with all the other system tray pop-ups, which put their Settings 
button all the way over to the right.
  
  Hmm.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22075

To: broulik, #plasma, #vdg, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22075: [Notifications] Swap configure and clear buttons in full representation header

2019-06-24 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:11387ca37f91: [Notifications] Swap configure and clear 
buttons in full representation header (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22075?vs=60588=60606

REVISION DETAIL
  https://phabricator.kde.org/D22075

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: broulik, #plasma, #vdg, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22075: [Notifications] Swap configure and clear buttons in full representation header

2019-06-24 Thread Kai Uwe Broulik
broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This makes it consistent with the configure button of the items in the list 
below.
  
  BUG: 409140
  FIXED-IN: 5.16.2

TEST PLAN
  F6931175: Screenshot_20190624_173300.png 

  When the history is empty, the clear button is disabled instead of hidden to 
keep the configure button from shifting around

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22075

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart