D22162: taskmanager: performance

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:50c391cc6c1b: taskmanager: performance (authored by apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22162?vs=60854=61012

REVISION DETAIL
  https://phabricator.kde.org/D22162

AFFECTED FILES
  libtaskmanager/tasktools.cpp

To: apol, #plasma, hein
Cc: hein, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22162: taskmanager: performance

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  In D22162#488378 , @ngraham wrote:
  
  > Not sure if it's related, but while you're at it, would you be able to also 
fix these errors when hovering over a pinned item:
  >
  >   
file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml:347:
 Unable to assign [undefined] to int
  >   
file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml:375:
 TypeError: Type error
  >
  
  
  They're not related, so shouldn't be handled in this review (see also fregl's 
patches).

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22162

To: apol, #plasma, hein
Cc: hein, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22162: taskmanager: performance

[Nathaniel Graham]

ngraham added a comment.


  Not sure if it's related, but while you're at it, would you be able to also 
fix these errors when hovering over a pinned item:
  

file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml:347:
 Unable to assign [undefined] to int

file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml:375:
 TypeError: Type error

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22162

To: apol, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22162: taskmanager: performance

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Don't do queries on unknown values.
  Don't create a KDesktopFile until we know we're going to need it

TEST PLAN
  Ran plasma with debugs, didn't see any regressions.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22162

AFFECTED FILES
  libtaskmanager/tasktools.cpp

To: apol, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart