D22223: Seek to end as mpris next action

[Markus Ebner]

seijikun created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
seijikun requested review of this revision.

REVISION SUMMARY
  Most pages where the mpris functionality is used will probably have an 
auto-continue feature for when the end of a media is reached.
  Now, if mpris sends the next-signal, seeking to the end of the video is 
probably the most reliable way of continuing to the next in line.
  Works like a charm on YouTube.
  
  Sorry if anything is wrong, this is my first contribution.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D3

AFFECTED FILES
  extension/content-script.js

To: seijikun
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22223: Seek to end as mpris next action

[Kai Uwe Broulik]

broulik added a comment.


  Thanks for your patch.
  `fastSeek` doesn't seem to be part of the HTML audio/video DOM API and also 
isn't supported by Chrome.
  A website should provide a `nexttrack` callback if it supports changing 
tracks, which YouTube does while watching playlists. Your patch would 
unconditionally seek, even if the website did.
  Also, you never announce that we can go next (and I don't think we can tell), 
so this shouldn't even work, but that it does is a bug.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D3

To: seijikun, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22223: Seek to end as mpris next action

[Markus Ebner]

seijikun planned changes to this revision.
seijikun added a comment.


  Oh, I'm sorry. I had a look in this list here 
 and 
thought, that all methods without a warning triangle are good to go.
  I guess this one 
 
would be the way to go, then?
  
  > Also, you never announce that we can go next (and I don't think we can 
tell), so this shouldn't even work, but that it does is a bug.
  
  I noticed, that the Next-Button worked, even though the GUI-buttons in the 
MPRIS tray are disabled, but I couldn't find out how to announce that it's 
supported.
  
  > A website should provide a nexttrack callback if it supports changing 
tracks, which YouTube does while watching playlists.
  
  Is that what lines 217 to 226 are for, because that does not seem to work for 
me in Firefox? Neither with normal videos, nor in playlists.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D3

To: seijikun, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart