D22302: fix kstart5 crash on wayland

[Igor Kovalenko]

garrison created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
garrison requested review of this revision.

REVISION SUMMARY
  Make kstart query NETRootInfo only if it is running o QX11Info::isPlatformX11 
following porting guidelines.
  Verified by starting just crashed plasmashell via 'kstart5 plasmashell'
  BUG: 403965

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22302

AFFECTED FILES
  kstart/kstart.cpp

To: garrison
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22302: fix kstart5 crash on wayland

[Nathaniel Graham]

ngraham added a comment.


  @garrison, can you provide your email address so we can land this patch with 
correct authorship information? Thanks!

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22302

To: garrison, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22302: fix kstart5 crash on wayland

[Nathaniel Graham]

ngraham closed this revision.
ngraham added a subscriber: aacid.
ngraham added a comment.


  Oh, this was already landed, but Phab didn't notice because its commit 
message was altered to no longer include the `Differential Revision: 
https://phabricator.kde.org/D22302` text. Closing manually.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22302

To: garrison, davidedmundson
Cc: aacid, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22302: fix kstart5 crash on wayland

[Igor Kovalenko]

garrison added a comment.


  anyway I confirm email address is correct - and will use git next time

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22302

To: garrison, davidedmundson
Cc: aacid, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22302: fix kstart5 crash on wayland

[Albert Astals Cid]

aacid added a comment.


  In D22302#491786 , @ngraham wrote:
  
  > Oh, this was already landed, but Phab didn't notice because its commit 
message was altered to no longer include the `Differential Revision: 
https://phabricator.kde.org/D22302` text. Closing manually.
  
  
  Yeah, sorry about that, arc patch failed because of how the diff file was 
created and i forgot to manually add the differential line when recreating the 
commit

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22302

To: garrison, davidedmundson
Cc: aacid, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22302: fix kstart5 crash on wayland

[Nathaniel Graham]

ngraham added a comment.


  No worries!
  
  When landing a patch that was originally branched from master onto a 
different branch, I find that the following works well for me: 
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22302

To: garrison, davidedmundson
Cc: aacid, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart