D22312: [DeviceNotifications] Keep last message for each device
This revision was automatically updated to reflect the committed changes. Closed by commit R120:bf811e448c76: [DeviceNotifications] Keep last message for each device (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22312?vs=61292=61294 REVISION DETAIL https://phabricator.kde.org/D22312 AFFECTED FILES dataengines/devicenotifications/ksolidnotify.cpp To: bruns, #plasma, broulik, ngraham Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22312: [DeviceNotifications] Keep last message for each device
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I just noticed this a few days ago and it was annoying me. I tested with three flash drives and an external hard drive. Three correctly removed the notice after the disk was actually physically removed, and one removed it after the 5 second timeout. So I think the logic there seems robust enough. REPOSITORY R120 Plasma Workspace BRANCH cleanup_devicenotifier REVISION DETAIL https://phabricator.kde.org/D22312 To: bruns, #plasma, broulik, ngraham Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22312: [DeviceNotifications] Keep last message for each device
bruns created this revision. bruns added reviewers: Plasma, broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Ejecting e.g. a USB stick removes it from the bus (bus power is removed), but the last notification should be kept, otherwise a message like "The device can be savely removed" immediately disappears. Unfortunately it is almost impossible to tell when a device has been physically removed (only indirectly, when a new device is plugged into the same port), so allow some small leakage - in case the same device is later replugged, no leakage happens. TEST PLAN Card reader: 1.insert medium, mount, unmount -> message "Device can be savely removed" is shown in device notifier for 5 seconds 2. eject medium, reinsert -> device appears without message and with default label REPOSITORY R120 Plasma Workspace BRANCH cleanup_devicenotifier REVISION DETAIL https://phabricator.kde.org/D22312 AFFECTED FILES dataengines/devicenotifications/ksolidnotify.cpp To: bruns, #plasma, broulik, ngraham Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
