D22605: Set notifications entry icon size to medium

[Alex Debus]

alexde added a comment.


  > For pictures (like people's faces in messenger notifications) I would still 
prefer the lager icons, though.
  
  I have to admit, that I'm not very much satisfied myself with the size. It 
could be a bit larger, something between medium and large. Maby we should 
discard it again. :P

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22605

To: alexde, #vdg
Cc: broulik, pino, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22605: Set notifications entry icon size to medium

[Kai Uwe Broulik]

broulik added a comment.


  For pictures (like people's faces in messenger notifications) I would still 
prefer the lager icons, though.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22605

To: alexde, #vdg
Cc: broulik, pino, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22605: Set notifications entry icon size to medium

[Alex Debus]

alexde added a comment.


  > You must run cmake for the whole repository; once done that, you can cd to 
the applets/notifications/ subdirectory of the builddir, and build only that 
part.
  
  What I also needed to install is
  
kdesignerplugin
  
  then
  
  So the procedure is as follows:
  
  1. cd plasma-workspace (root folder)
  2. cmake -DCMAKE_INSTALL_PREFIX=/usr .
  3. cd applets/notifcation
  4. make -j6
  5. sudo make install
  6. Log out & log in
  
  Is there a simly way to not override my working plasma desktop files?
  
  I am now going to attach the screenshot above.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22605

To: alexde, #vdg
Cc: pino, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22605: Set notifications entry icon size to medium

[Pino Toscano]

pino added a comment.


  In D22605#499051 , @alexde wrote:
  
  > I would like to test it and post a screenshot, however I am not able to 
compile it:
  >
  > 1. I cloned the source from the git repository
  > 2. mkdir plasma-workspace/applets/notifications/build
  > 3. cd plasma-workspace/applets/notifications/build
  > 4. cmake ..
  >
  >   This resulted in ``` CMake Error at CMakeLists.txt:11 
(kcoreaddons_desktop_to_json): Unknown CMake command 
"kcoreaddons_desktop_to_json". ```
  
  
  You must run cmake for the whole repository; once done that, you can cd to 
the applets/notifications/ subdirectory of the builddir, and build only that 
part.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22605

To: alexde, #vdg
Cc: pino, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22605: Set notifications entry icon size to medium

[Alex Debus]

alexde added a comment.


  I would like to test it and post a screenshot, however I am not able to 
compile it:
  
  1. I cloned the source from the git repository
  2. mkdir plasma-workspace/applets/notifications/build
  3. cd plasma-workspace/applets/notifications/build
  4. cmake ..
  
  This resulted in
  
CMake Error at CMakeLists.txt:11 (kcoreaddons_desktop_to_json):
  Unknown CMake command "kcoreaddons_desktop_to_json".
  
  
  
  5. I then added
  
find_package(KF5Plasma REQUIRED)
  
  to the CMakeLists.txt, which at least make cmake succeed. However, when I 
tried to compile it with
  
  6. make
  
  It breaks with
  
Scanning dependencies of target plasma_applet_notifications
[ 20%] Building CXX object 
CMakeFiles/plasma_applet_notifications.dir/notificationapplet.o

/path/KDE/plasma-workspace/applets/notifications/notificationapplet.cpp:27:10: 
error: QQuickItem: File or directory not found
   27 | #include 
  |  ^~~~
Compilation terminated.
make[2]: *** [CMakeFiles/plasma_applet_notifications.dir/build.make:63: 
CMakeFiles/plasma_applet_notifications.dir/notificationapplet.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:233: 
CMakeFiles/plasma_applet_notifications.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
  
  I have the Qt development and kcoreaddons' files installed. I thought this 
procedure would be more straight forward. I'm looking forward to your advice. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22605

To: alexde, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart