D22630: Slow down the busy indicator's rotation speed

[Nathaniel Graham]

ngraham added a comment.


  Yup, See D22645  and D22646 
. Turns out that they were already using a 
different duration, so with those patch landed, all the busy indicators will 
use the same rotational speed.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D22630

To: ngraham, #vdg, filipf, cullmann
Cc: broulik, cfeck, filipf, plasma-devel, cullmann, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22630: Slow down the busy indicator's rotation speed

[Kai Uwe Broulik]

broulik added a comment.


  Also, Plasma's `BusyIndicator` should maybe get the same treatment?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D22630

To: ngraham, #vdg, filipf, cullmann
Cc: broulik, cfeck, filipf, plasma-devel, cullmann, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22630: Slow down the busy indicator's rotation speed

[Christoph Feck]

cfeck added a comment.


  Do we need a matching commit in KWidgetsAddons? See 
https://commits.kde.org/kwidgetsaddons/2631be903f947872f67c9e2063950345dda9033e

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D22630

To: ngraham, #vdg, filipf, cullmann
Cc: cfeck, filipf, plasma-devel, cullmann, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22630: Slow down the busy indicator's rotation speed

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:217fc7530b75: Slow down the busy indicators 
rotation speed (authored by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22630?vs=62239=62240#toc

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22630?vs=62239=62240

REVISION DETAIL
  https://phabricator.kde.org/D22630

AFFECTED FILES
  org.kde.desktop/BusyIndicator.qml

To: ngraham, #vdg, filipf, cullmann
Cc: filipf, plasma-devel, cullmann, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22630: Slow down the busy indicator's rotation speed

[Nathaniel Graham]

ngraham added a comment.


  *sigh*
  
  Nothing's ever easy with you, is it, arc?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  slower-busy-indicator

REVISION DETAIL
  https://phabricator.kde.org/D22630

To: ngraham, #vdg, filipf, cullmann
Cc: filipf, plasma-devel, cullmann, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22630: Slow down the busy indicator's rotation speed

[Nathaniel Graham]

ngraham updated this revision to Diff 62239.
ngraham added a comment.


  Rebase

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22630?vs=62236=62239

BRANCH
  slower-busy-indicator

REVISION DETAIL
  https://phabricator.kde.org/D22630

AFFECTED FILES
  org.kde.desktop/BusyIndicator.qml
  org.kde.desktop/ComboBox.qml
  org.kde.desktop/private/MobileTextActionsToolBar.qml
  tests/LineEditWithClearButton.qml

To: ngraham, #vdg, filipf, cullmann
Cc: filipf, plasma-devel, cullmann, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22630: Slow down the busy indicator's rotation speed

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.


  Jup, looks less iritating.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  slower-busy-indicator

REVISION DETAIL
  https://phabricator.kde.org/D22630

To: ngraham, #vdg, filipf, cullmann
Cc: filipf, plasma-devel, cullmann, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22630: Slow down the busy indicator's rotation speed

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  The FPS before was a little bit gamer-esque.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  slower-busy-indicator

REVISION DETAIL
  https://phabricator.kde.org/D22630

To: ngraham, #vdg, filipf
Cc: filipf, plasma-devel, cullmann, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22630: Slow down the busy indicator's rotation speed

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The busy indicator spins really fast and it's kind of disorienting. Let's 
slow it down.

TEST PLAN
  Before: F7070385: Before.webm 
  After: F7070386: After.webm 
  
  Please excuse the slight choppiness of the video; it's not like that in real 
life.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  slower-busy-indicator

REVISION DETAIL
  https://phabricator.kde.org/D22630

AFFECTED FILES
  org.kde.desktop/BusyIndicator.qml

To: ngraham, #vdg
Cc: plasma-devel, cullmann, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart