D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

[Radoslav Georgiev]

rgeorgiev abandoned this revision.
rgeorgiev added a comment.


  @broulik Hmm, now I think that I understood the rationale why SoundCloud 
support is activated using the **Enhanced Media Controls** option.  As you 
commented on my other revision (D22632 ), 
SoundCloud uses the Media Session API, support for which is enabled using the 
aforementioned option.  My fault for making uniformed changes :D

REVISION DETAIL
  https://phabricator.kde.org/D22631

To: rgeorgiev
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

[Radoslav Georgiev]

rgeorgiev planned changes to this revision.
rgeorgiev added a comment.


  In D22631#499815 , @broulik wrote:
  
  > I'm confused - what does this change? There's no context, so I can't tell 
where it's being moved to. Soundcloud works fine here. You might want to enable 
"Enhanced Media Controls" in settings.
  
  
  Well, the reason why I made these changes is that in my understanding, the 
enabling of the **Media Controls** option should ensure the basic functioning 
of media controls for all sites (even if the **Enhanced Media Controls** option 
is disabled, which currently breaks SoundCloud support).  That's why I decided 
to move the logic which detects media player (i.e.  `audio` or `video`) 
elements being added to the page after its loading from the 
`loadMediaSessionsShim` function (which is executed only if the **Enhanced 
Media Controls** option is enabled) to the `loadMpris` function (which is 
executed if the **Media Controls** option is enabled).
  
  To clear any misunderstanding on my side, what's the exact purpose of the 
**Enhanced Media Controls** option?  I thought that the idea behind it is to 
toggle the displaying of the metadata and the thumbnail for the currently 
playing media.

REVISION DETAIL
  https://phabricator.kde.org/D22631

To: rgeorgiev
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

[Kai Uwe Broulik]

broulik added a comment.


  I'm confused - what does this change? There's no context, so I can't tell 
where it's being moved to. Soundcloud works fine here. You might want to enable 
"Enhanced Media Controls" in settings.

REVISION DETAIL
  https://phabricator.kde.org/D22631

To: rgeorgiev
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

[Radoslav Georgiev]

rgeorgiev updated this revision to Diff 62249.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22631?vs=62241=62249

REVISION DETAIL
  https://phabricator.kde.org/D22631

AFFECTED FILES
  extension/content-script.js

To: rgeorgiev
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

[Radoslav Georgiev]

rgeorgiev created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rgeorgiev requested review of this revision.

REVISION SUMMARY
  Perform registering of dynamically-added players in all cases when media 
controls are enabled, thereby making basic SoundCloud support work.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D22631

AFFECTED FILES
  extension/content-script.js

To: rgeorgiev
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart