D22700: Sync scaling DPI from Plasma to SDDM

2020-05-03 Thread Yunhe Guo 
guoyunhe added a comment.


  In D22700#662323 , @filipf wrote:
  
  > In D22700#662134 , @guoyunhe 
wrote:
  >
  > > When I press the synchronize button, it looks like the `-dpi 144` (scale 
x1.5) option makes the UI elements huge (feel like x2 scale or more):
  > >
  > > F8280985: IMG_20200503_152810.jpg 
  >
  >
  > -dpi 144 works the same for me in Plasma and SDDM, but do file a bug under 
systemsettings->kcm_sddm and copy paste what you have in 
`/etc/sddm.conf.d/kde_settings.conf`. I'll investigate.
  
  
  I think it is more likely an SDDM issue, because its document says so and the 
issue can be reproduced without using kcm_sddm. So I reported it here 
https://github.com/sddm/sddm/issues/1253

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22700

To: filipf, #plasma, davidedmundson, ngraham
Cc: guoyunhe, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22700: Sync scaling DPI from Plasma to SDDM

2020-05-03 Thread Filip Fila 
filipf added a comment.


  In D22700#662134 , @guoyunhe wrote:
  
  > When I press the synchronize button, it looks like the `-dpi 144` (scale 
x1.5) option makes the UI elements huge (feel like x2 scale or more):
  >
  > F8280985: IMG_20200503_152810.jpg 
  
  
  -dpi 144 works the same for me in Plasma and SDDM, but do file a bug under 
systemsettings->kcm_sddm and copy paste what you have in 
`/etc/sddm.conf.d/kde_settings.conf`. I'll investigate.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22700

To: filipf, #plasma, davidedmundson, ngraham
Cc: guoyunhe, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22700: Sync scaling DPI from Plasma to SDDM

2020-05-03 Thread Yunhe Guo 
guoyunhe added a comment.


  When I press the synchronize button, it looks like the `-dpi 144` (scale 
x1.5) option makes the UI elements huge (feel like x2 scale or more):
  
  F8280985: IMG_20200503_152810.jpg 

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22700

To: filipf, #plasma, davidedmundson, ngraham
Cc: guoyunhe, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22700: Sync scaling DPI from Plasma to SDDM

2019-07-24 Thread Filip Fila 
filipf added a comment.


  I believe you're right. Let me know if this is a good fix: 
https://cgit.kde.org/sddm-kcm.git/commit/?id=a48e07c8156a10a7519f18ec72a9608fc5bfaa0a

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22700

To: filipf, #plasma, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22700: Sync scaling DPI from Plasma to SDDM

2019-07-24 Thread David Edmundson 
davidedmundson added a comment.


  One potentially major issue that if I'm right needs fixing ASAP

INLINE COMMENTS

> advanceconfig.cpp:156
> +KConfigGroup dpiConfigGroup(, "General");
> +QString dpiValue = QStringLiteral("-dpi ") + 
> dpiConfigGroup.readEntry("forceFontDPI");
> +

What are you going to write if this entry is missing?

I suspect you'll write just

"-dpi "  into ServerArguments

and then X11 will run with "X11 -dpi"   expect another argument and simply fail 
to load?

> advanceconfig.cpp:157
> +QString dpiValue = QStringLiteral("-dpi ") + 
> dpiConfigGroup.readEntry("forceFontDPI");
> +
>  KConfig numLockConfig(QStringLiteral("kcminputrc"));

As a coding note it's useful to make sure the data in the variables matches 
their name.

In this case

"dpiValue" isn't just the DPI value, it's a string formatted as X server 
arguments "-dpi" here.

So I would suggest either renaming or (probably easier with the other fix) 
adding the "-dpi "prefix when you insert it into the map.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22700

To: filipf, #plasma, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22700: Sync scaling DPI from Plasma to SDDM

2019-07-24 Thread Filip Fila 
This revision was automatically updated to reflect the committed changes.
Closed by commit R123:f909a8ab0ea3: Sync scaling DPI from Plasma to SDDM 
(authored by filipf).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22700?vs=62439=62456

REVISION DETAIL
  https://phabricator.kde.org/D22700

AFFECTED FILES
  sddmauthhelper.cpp
  src/advanceconfig.cpp
  src/ui/advanceconfig.ui

To: filipf, #plasma, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22700: Sync scaling DPI from Plasma to SDDM

2019-07-23 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


   

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  sync-scaling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22700

To: filipf, #plasma, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22700: Sync scaling DPI from Plasma to SDDM

2019-07-23 Thread Filip Fila 
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This patch adds scaling to the list of Plasma settings that can be synced 
with SDDM.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  sync-scaling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22700

AFFECTED FILES
  sddmauthhelper.cpp
  src/advanceconfig.cpp
  src/ui/advanceconfig.ui

To: filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart