D22716: Add icons to Categories, Installed, and Sources globaldrawer entries
ngraham added inline comments. INLINE COMMENTS > GB_2 wrote in KNSBackend.cpp:214 > I think we can use the icon `plugins` here. Submit a patch! :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D22716 To: leinir, #discover_software_store, #vdg, ngraham, apol Cc: GB_2, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22716: Add icons to Categories, Installed, and Sources globaldrawer entries
GB_2 added inline comments.
INLINE COMMENTS
> KNSBackend.cpp:214
> };
> -auto actualCategory = new Category(m_displayName,
> QStringLiteral("plasma"), filters, backendName, categories, QUrl(), true);
> +const auto iconName = knsrcPlasma.contains(fileName)?
> QStringLiteral("plasma") : QStringLiteral("applications-other");
> +auto actualCategory = new Category(m_displayName, iconName, filters,
> backendName, categories, QUrl(), true);
I think we can use the icon `plugins` here.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D22716
To: leinir, #discover_software_store, #vdg, ngraham, apol
Cc: GB_2, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen,
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, mart
D22716: Add icons to Categories, Installed, and Sources globaldrawer entries
This revision was automatically updated to reflect the committed changes. Closed by commit R134:29fb6ce9e369: Add icons to Categories, Installed, and Sources globaldrawer entries (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22716?vs=62471=62521 REVISION DETAIL https://phabricator.kde.org/D22716 AFFECTED FILES discover/qml/DiscoverDrawer.qml discover/qml/DiscoverWindow.qml libdiscover/Category/CategoriesReader.cpp libdiscover/backends/KNSBackend/KNSBackend.cpp To: leinir, #discover_software_store, #vdg, ngraham, apol Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22716: Add icons to Categories, Installed, and Sources globaldrawer entries
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Awesome! I've wanted this for a long time. LGTM. We can tweak the icons and their assignments in subsequent patches if necessary. REPOSITORY R134 Discover Software Store BRANCH more-globaldrawer-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22716 To: leinir, #discover_software_store, #vdg, ngraham Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22716: Add icons to Categories, Installed, and Sources globaldrawer entries
leinir created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY At some point, icons were removed from a number of entries in the global drawer, but with the many other changes which have happened since then this now leaves the sidebar looking somewhere between overly vacant and broken (with some overweight toward the latter). This patch adds these icons back in, as well as a couple of others, which results in a global drawer which looks considerably more completely loaded. This is furthermore based on feedback from the Plasma Mobile Todo[1] notes entry, which at time of writing contains the following (amongst others): Discover: Global toolbar: - Installed and Sources should have icons - Categories should either have icons or be less indented [1] https://notes.kde.org/p/plasma-mobile-todo Parent Categories created by the category reader TEST PLAN See before without icons looks empty and just a tiny bit broken, and after with icons included looks fully populated (screenshots incoming) REPOSITORY R134 Discover Software Store BRANCH more-globaldrawer-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22716 AFFECTED FILES discover/qml/DiscoverDrawer.qml discover/qml/DiscoverWindow.qml libdiscover/Category/CategoriesReader.cpp libdiscover/backends/KNSBackend/KNSBackend.cpp To: leinir Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
