D22869: [Converter Runner] Support fractional units
This revision was automatically updated to reflect the committed changes. Closed by commit R114:6f1cadb5882c: [Converter Runner] Support fractional units (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22869?vs=62887=62896 REVISION DETAIL https://phabricator.kde.org/D22869 AFFECTED FILES runners/converter/converterrunner.cpp To: broulik, #plasma, kossebau, ngraham Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22869: [Converter Runner] Support fractional units
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. OMG, this is great stuff! Works great, and code looks sane. I couldn't find any regressions in my testing. Next, the real trick will be to combine this with calculation support so you can do `5/8" + 3/16"`. :-) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22869 To: broulik, #plasma, kossebau, ngraham Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22869: [Converter Runner] Support fractional units
broulik created this revision. broulik added reviewers: Plasma, kossebau. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 409216 FIXED-IN: 5.17.0 CHANGELOG: Converter runner can now convert fractional units, such as 3/8" TEST PLAN Typed `3/8"`, got results for 0,375", i.e. 0.9525cm Typed `3/8 in, got the same results Typed `3/8" in cm`, got it converted to just centimeters Typed `3/0"`, didn't get any results Typed `3"`, still works Can still convert units with a slash, such as "50km/h" = 31mph. Due to how the runner identifies numbers and units, you cannot have spaces between the slashes, i.e. `3 / 8 in` doesn't work REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22869 AFFECTED FILES runners/converter/converterrunner.cpp To: broulik, #plasma, kossebau Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
