D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon

2019-08-02 Thread Filip Fila 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cd027ce844ed: [applets/notifications] Try to not have the 
notification count numbers overflow… (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22878?vs=62923=62982

REVISION DETAIL
  https://phabricator.kde.org/D22878

AFFECTED FILES
  applets/notifications/package/contents/ui/CompactRepresentation.qml

To: filipf, broulik, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon

2019-08-01 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Much better.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  notification-count-no-overflow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22878

To: filipf, broulik, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon

2019-08-01 Thread Filip Fila 
filipf updated this revision to Diff 62923.
filipf added a comment.


  better code

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22878?vs=62911=62923

BRANCH
  notification-count-no-overflow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22878

AFFECTED FILES
  applets/notifications/package/contents/ui/CompactRepresentation.qml

To: filipf, broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon

2019-08-01 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> CompactRepresentation.qml:97
>  anchors.centerIn: parent
> -width: Math.round(Math.min(parent.width, parent.height) * 0.75)
> +width: text.length > 1 ? Math.round(Math.min(parent.width, 
> parent.height) * 0.67) : Math.round(Math.min(parent.width, parent.height) * 
> 0.75)
>  height: width

Can you rearrange that a bit

  width: Math.round(Math.min(parent.width, parent.height) * (text.length > 1 ? 
0.67 : 0.75))`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22878

To: filipf, broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon

2019-08-01 Thread Filip Fila 
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  When the notification count is in double digits, the numbers can overflow the 
icons which is meant to contain them.
  
  This patch checks if there is more than 1 digit and then slightly reduces the 
size of the numbers.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  notification-count-no-overflow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22878

AFFECTED FILES
  applets/notifications/package/contents/ui/CompactRepresentation.qml

To: filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart