D22880: Rename "Plasma Theme" to "Plasma Style"

[Nathaniel Graham]

ngraham marked an inline comment as done.
ngraham added inline comments.

INLINE COMMENTS

> GB_2 wrote in kcm_desktoptheme.desktop:41
> You forgot to change the name here too.

Oops, sorry! Fixed in 2bedabd96d37c48a67a80dcc48f3368b1e9713ef 
.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22880

To: ngraham, #vdg, #plasma, GB_2
Cc: leinir, GB_2, plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, 
fbampaloukas, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22880: Rename "Plasma Theme" to "Plasma Style"

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> kcm_desktoptheme.desktop:41
>  Name[zh_TW]=Plasma 主題
>  Comment=Choose Plasma theme
>  Comment[ca]=Trieu el tema del Plasma

You forgot to change the name here too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22880

To: ngraham, #vdg, #plasma, GB_2
Cc: leinir, GB_2, plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, 
fbampaloukas, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22880: Rename "Plasma Theme" to "Plasma Style"

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5b7a43d2ad8d: Rename "Plasma Theme" to 
"Plasma Style" (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22880?vs=62927&id=62999

REVISION DETAIL
  https://phabricator.kde.org/D22880

AFFECTED FILES
  doc/kcontrol/desktopthemedetails/index.docbook
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm_desktoptheme.desktop
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/package/metadata.desktop
  kcms/desktoptheme/plasma-themes.knsrc

To: ngraham, #vdg, #plasma, GB_2
Cc: leinir, GB_2, plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, 
fbampaloukas, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22880: Rename "Plasma Theme" to "Plasma Style"

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> ngraham wrote in plasma-themes.knsrc:42
> > The KDE Store category name should probably be updated too.
> 
> You mean here? What does this actually do?

I mean in the actual store online :-)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  plasma-theme-to-plasma-style (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22880

To: ngraham, #vdg, #plasma, GB_2
Cc: leinir, GB_2, plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, 
fbampaloukas, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22880: Rename "Plasma Theme" to "Plasma Style"

[Nathaniel Graham]

ngraham added a subscriber: leinir.
ngraham added inline comments.

INLINE COMMENTS

> plasma-themes.knsrc:42
>  ProvidersUrl=https://download.kde.org/ocs/providers.xml
>  Categories=Plasma Theme
>  StandardResource=tmp

> The KDE Store category name should probably be updated too.

You mean here? What does this actually do?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  plasma-theme-to-plasma-style (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22880

To: ngraham, #vdg, #plasma, GB_2
Cc: leinir, GB_2, plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, 
fbampaloukas, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22880: Rename "Plasma Theme" to "Plasma Style"

[Björn Feber]

GB_2 accepted this revision as: VDG, GB_2.
GB_2 added a comment.
This revision is now accepted and ready to land.


  The KDE Store category name should probably be updated too.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  plasma-theme-to-plasma-style (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22880

To: ngraham, #vdg, #plasma, GB_2
Cc: GB_2, plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, 
fbampaloukas, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22880: Rename "Plasma Theme" to "Plasma Style"

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added projects: Plasma, Documentation.
Herald added subscribers: kde-doc-english, plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This implements one of the changes decided upon in T11314 
. The rationale is as follows:
  
  We don't call anything else a "Theme" in the appearance section; we use the 
word "style"
  if we have to use anything, preferring to not use any word at all. Since the 
app
  settings use "Style", we should do the same thing for the contrasting Plasma 
setting.

TEST PLAN
  F7134998: Plasma Style.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  plasma-theme-to-plasma-style (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22880

AFFECTED FILES
  doc/kcontrol/desktopthemedetails/index.docbook
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm_desktoptheme.desktop
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/package/metadata.desktop
  kcms/desktoptheme/plasma-themes.knsrc

To: ngraham, #vdg, #plasma
Cc: plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart