D22885: Add global animation speed slider to workspace options KCMGNU nano 4.3/tmp/edit.fd801hu0c34so8k8/new-commitModifiedAdd global animation speed slider to workspace options KCM
anthonyfieroni added a comment. Since we have 4 values on right / left, 0 should be the default one, no? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22885 To: davidedmundson, #plasma Cc: anthonyfieroni, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22885: Add global animation speed slider to workspace options KCMGNU nano 4.3/tmp/edit.fd801hu0c34so8k8/new-commitModifiedAdd global animation speed slider to workspace options KCM
davidedmundson updated this revision to Diff 62956. davidedmundson added a comment. update Updating D22885: Add global animation speed slider to workspace options KCM === GNU nano 4.3 /tmp/edit.fd801hu0c34so8k8/new-commit Modified Add global animation speed slider to workspace options KCM REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22885?vs=62949=62956 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22885 AFFECTED FILES kcms/workspaceoptions/package/contents/ui/main.qml kcms/workspaceoptions/workspaceoptions.cpp kcms/workspaceoptions/workspaceoptions.h To: davidedmundson, #plasma Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22885: Add global animation speed slider to workspace options KCMGNU nano 4.3/tmp/edit.fd801hu0c34so8k8/new-commitModifiedAdd global animation speed slider to workspace options KCM
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Introduce a new config entry into kdeglobals AnimationSpeed that will control /all/ animation speeds in kwin and plasma themes and Qt styles and kirigami. The value stored is a multiplier. i.e 1 == normal speed, 0.5 = twice as fast, 2 = twice as slow. 0 is a special value meaning "disable animations" The QML is a bit complex to represent a logarithmic slider that goes 4x, 2x, 1x, 0.5x, 0.25x, 0.125x but still allowing a user to type arbitrary values into their config - Note @kbroulik This is reversed it from what we coded together, because I decided it was confusing. Needs relevant patches through the rest of the stack before merging. Also kwin has some asserts on 0 speed animations that need addressing. You also need an up-to-date kconfig and qqc2-desktop-style for bugfixes TEST PLAN Looked at config REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D22885 AFFECTED FILES kcms/workspaceoptions/package/contents/ui/main.qml kcms/workspaceoptions/workspaceoptions.cpp kcms/workspaceoptions/workspaceoptions.h To: davidedmundson, #plasma Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart