D22925: Fix POTD doesn't update

2019-08-08 Thread Nathaniel Graham 
ngraham added a comment.


  Great, I'll test for a few days as well. The code looks sane.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22925

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22925: Fix POTD doesn't update

2019-08-08 Thread Yunhe Guo 
guoyunhe added a comment.


  It works now. Tested with several different POTD providers.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22925

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22925: Fix POTD doesn't update

2019-08-07 Thread Yunhe Guo 
guoyunhe updated this revision to Diff 63301.
guoyunhe added a comment.


  Add import

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22925?vs=63300&id=63301

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22925

AFFECTED FILES
  dataengines/potd/cachedprovider.cpp
  dataengines/potd/potd.cpp

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22925: Fix POTD doesn't update

2019-08-07 Thread Yunhe Guo 
guoyunhe updated this revision to Diff 63300.
guoyunhe edited the summary of this revision.
guoyunhe added a comment.


  Fix CacheProvider's cache validation function

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22925?vs=63061&id=63300

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22925

AFFECTED FILES
  dataengines/potd/cachedprovider.cpp
  dataengines/potd/potd.cpp

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22925: Fix POTD doesn't update

2019-08-07 Thread Yunhe Guo 
guoyunhe added a comment.


  This is not working. Unsplash wallpapers still don't update daily. I need 
further debugging.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22925

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22925: Fix POTD doesn't update

2019-08-04 Thread Yunhe Guo 
guoyunhe added a comment.


  In D22925#506462 , @ngraham wrote:
  
  > Have you tested to make sure this doesn't break other providers?
  
  
  I need several days to test because it only change once a day... (changing 
local time won't work)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22925

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22925: Fix POTD doesn't update

2019-08-04 Thread Nathaniel Graham 
ngraham added a comment.


  Have you tested to make sure this doesn't break other providers?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22925

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22925: Fix POTD doesn't update

2019-08-04 Thread Yunhe Guo 
guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  Previous patch for Unsplash Wallpapers changed the identifier format. So we 
can not simply detect whether an identifier contains date by looking for `:`. 
This patch detect date string with regular expression.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22925

AFFECTED FILES
  dataengines/potd/potd.cpp

To: guoyunhe
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart