D23049: Add Kirigami ListSection component

2019-08-09 Thread Björn Feber 
GB_2 updated this revision to Diff 63430.
GB_2 added a comment.


  Rename to ListSectionHeader

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23049?vs=63429=63430

BRANCH
  add-listsection-component (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23049

AFFECTED FILES
  Mainpage.dox
  kirigami.qrc.in
  src/controls/ListSectionHeader.qml
  src/controls/plugins.qmltypes
  src/kirigamiplugin.cpp
  src/qmldir

To: GB_2, #kirigami, #vdg, mart
Cc: davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, domson, 
dkardarakos, apol, davidedmundson, mart, hein

D23049: Add Kirigami ListSection component

2019-08-09 Thread Nathaniel Graham 
ngraham added a comment.


  In D23049#509309 , @GB_2 wrote:
  
  > In D23049#509301 , @ngraham 
wrote:
  >
  > > Maybe call it a `ListSectionHeader` or just `SectionHeader`?
  >
  >
  > I think just the word section is more accurate, because that's what the 
property that it will be used in is called and header could mean only a heading 
label.
  
  
  Hmm, that's not how I interpreted it. This component isn't a whole section, 
as its name implies; it's just the thing that goes above a section (i.e. a 
header)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23049

To: GB_2, #kirigami, #vdg, mart
Cc: davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, domson, 
dkardarakos, apol, davidedmundson, mart, hein

D23049: Add Kirigami ListSection component

2019-08-09 Thread Björn Feber 
GB_2 updated this revision to Diff 63429.
GB_2 added a comment.


  Use correct background color

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23049?vs=63428=63429

BRANCH
  add-listsection-component (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23049

AFFECTED FILES
  Mainpage.dox
  kirigami.qrc.in
  src/controls/ListSection.qml
  src/controls/plugins.qmltypes
  src/kirigamiplugin.cpp
  src/qmldir

To: GB_2, #kirigami, #vdg, mart
Cc: davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, domson, 
dkardarakos, apol, davidedmundson, mart, hein

D23049: Add Kirigami ListSection component

2019-08-09 Thread Björn Feber 
GB_2 updated this revision to Diff 63428.
GB_2 added a comment.


  Set `sectionDelegate` to `true`

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23049?vs=63426=63428

BRANCH
  add-listsection-component (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23049

AFFECTED FILES
  Mainpage.dox
  kirigami.qrc.in
  src/controls/ListSection.qml
  src/controls/plugins.qmltypes
  src/kirigamiplugin.cpp
  src/qmldir

To: GB_2, #kirigami, #vdg, mart
Cc: davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, domson, 
dkardarakos, apol, davidedmundson, mart, hein

D23049: Add Kirigami ListSection component

2019-08-09 Thread David Redondo 
davidre added a comment.


  Should this set ` sectionDelegate: true` and not expose this to the outside?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23049

To: GB_2, #kirigami, #vdg, mart
Cc: davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, domson, 
dkardarakos, apol, davidedmundson, mart, hein

D23049: Add Kirigami ListSection component

2019-08-09 Thread Björn Feber 
GB_2 updated this revision to Diff 63426.
GB_2 added a comment.


  Update copyright

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23049?vs=63425=63426

BRANCH
  add-listsection-component (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23049

AFFECTED FILES
  Mainpage.dox
  kirigami.qrc.in
  src/controls/ListSection.qml
  src/controls/plugins.qmltypes
  src/kirigamiplugin.cpp
  src/qmldir

To: GB_2, #kirigami, #vdg
Cc: ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, domson, dkardarakos, 
apol, davidedmundson, mart, hein

D23049: Add Kirigami ListSection component

2019-08-09 Thread Björn Feber 
GB_2 added a comment.


  In D23049#509301 , @ngraham wrote:
  
  > Maybe call it a `ListSectionHeader` or just `SectionHeader`?
  
  
  I think just the word section is more accurate, because that's what the 
property that it will be used in is called and header could mean only a heading 
label.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23049

To: GB_2, #kirigami, #vdg
Cc: ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, domson, dkardarakos, 
apol, davidedmundson, mart, hein

D23049: Add Kirigami ListSection component

2019-08-09 Thread Björn Feber 
GB_2 added inline comments.

INLINE COMMENTS

> ngraham wrote in ListSection.qml:28
> coherent -> consistent

I just copied it from the other list items :-)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23049

To: GB_2, #kirigami, #vdg
Cc: ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, domson, dkardarakos, 
apol, davidedmundson, mart, hein

D23049: Add Kirigami ListSection component

2019-08-09 Thread Nathaniel Graham 
ngraham added a comment.


  Maybe call it a `ListSectionHeader` or just `SectionHeader`?

INLINE COMMENTS

> ListSection.qml:2
> +/*
> + *   Copyright 2010 Marco Martin 
> + *

You made this, so it's your copyright

> ListSection.qml:28
> + *
> + * It's intended to make all listviews look coherent.
> + *

coherent -> consistent

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23049

To: GB_2, #kirigami, #vdg
Cc: ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, domson, dkardarakos, 
apol, davidedmundson, mart, hein

D23049: Add Kirigami ListSection component

2019-08-09 Thread Björn Feber 
GB_2 updated this revision to Diff 63425.
GB_2 added a comment.


  Remove duplicate AbstractListItem

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23049?vs=63424=63425

BRANCH
  add-listsection-component (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23049

AFFECTED FILES
  Mainpage.dox
  kirigami.qrc.in
  src/controls/ListSection.qml
  src/controls/plugins.qmltypes
  src/kirigamiplugin.cpp
  src/qmldir

To: GB_2, #kirigami, #vdg
Cc: #vdg, plasma-devel, #kirigami, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D23049: Add Kirigami ListSection component

2019-08-09 Thread Björn Feber 
GB_2 created this revision.
GB_2 added reviewers: Kirigami, VDG.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Adds a standard ListSection component to make ListView sections look 
consistent.
  F7181620: Kirigami ListSection.png 

TEST PLAN
  Run the example with `qmlscene`: F7181621: ListSectionExample.qml 


REPOSITORY
  R169 Kirigami

BRANCH
  add-listsection-component (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23049

AFFECTED FILES
  Mainpage.dox
  kirigami.qrc.in
  src/controls/ListSection.qml
  src/controls/plugins.qmltypes
  src/kirigamiplugin.cpp
  src/qmldir

To: GB_2, #kirigami, #vdg
Cc: #vdg, plasma-devel, #kirigami, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein