D23308: Add a warning message about needing globally installed theme files
This revision was automatically updated to reflect the committed changes. Closed by commit R123:4b2171bb3db3: Add a warning message about needing globally installed theme files (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23308?vs=65084&id=65278 REVISION DETAIL https://phabricator.kde.org/D23308 AFFECTED FILES src/advancedconfig.cpp src/ui/advancedconfig.ui To: filipf, #plasma, davidedmundson, #vdg, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23308: Add a warning message about needing globally installed theme files
filipf updated this revision to Diff 65084. filipf added a comment. - remove "in the root directory" REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23308?vs=64997&id=65084 BRANCH sync-warning (branched from master) REVISION DETAIL https://phabricator.kde.org/D23308 AFFECTED FILES src/advancedconfig.cpp src/ui/advancedconfig.ui To: filipf, #plasma, davidedmundson, #vdg, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23308: Add a warning message about needing globally installed theme files
ngraham added inline comments. INLINE COMMENTS > ngraham wrote in advancedconfig.ui:246 > Maybe mention the actual path "In the root directory" is both unhelpful and > inaccurate if read literally All right, just get rid of "(in the root directory)" then. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D23308 To: filipf, #plasma, davidedmundson, #vdg, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23308: Add a warning message about needing globally installed theme files
filipf added inline comments. INLINE COMMENTS > filipf wrote in advancedconfig.ui:246 > I would assume it's `/usr/share/` but I don't know it that's true for all > distros and BSD? /usr/share would just be less inaccurate then anyway, these "theme files" mentioned are all installed in different locations so I'd have to list all of them: /usr/share/fonts /usr/share/plasma/desktop-theme /usr/share/icons REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D23308 To: filipf, #plasma, davidedmundson, #vdg, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23308: Add a warning message about needing globally installed theme files
filipf added inline comments. INLINE COMMENTS > ngraham wrote in advancedconfig.ui:154 > Looks unrelated This reverts an unrelated change I made in: https://github.com/KDE/sddm-kcm/commit/f9e753551cdd8f41ca2fb15bfc6610afc5e09a59#diff-19d487873d9e40d7bbcc52ca9926efceR177 > ngraham wrote in advancedconfig.ui:171 > Looks unrelated This reverts an unrelated change I made in: https://github.com/KDE/sddm-kcm/commit/f9e753551cdd8f41ca2fb15bfc6610afc5e09a59#diff-19d487873d9e40d7bbcc52ca9926efceR177 > ngraham wrote in advancedconfig.ui:246 > Maybe mention the actual path "In the root directory" is both unhelpful and > inaccurate if read literally I would assume it's `/usr/share/` but I don't know it that's true for all distros and BSD? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D23308 To: filipf, #plasma, davidedmundson, #vdg, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23308: Add a warning message about needing globally installed theme files
ngraham added inline comments. INLINE COMMENTS > advancedconfig.ui:154 > > - > + > Looks unrelated > advancedconfig.ui:171 > > - > + > Looks unrelated > advancedconfig.ui:246 > + > +Please note that theme files must be installed globally (in > the root directory) for settings synchronization to work. > + Maybe mention the actual path "In the root directory" is both unhelpful and inaccurate if read literally REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D23308 To: filipf, #plasma, davidedmundson, #vdg, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23308: Add a warning message about needing globally installed theme files
filipf updated this revision to Diff 64997. filipf added a comment. Rebase on master (hopefully) REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23308?vs=64170&id=64997 BRANCH sync-warning (branched from master) REVISION DETAIL https://phabricator.kde.org/D23308 AFFECTED FILES src/advancedconfig.cpp src/ui/advancedconfig.ui To: filipf, #plasma, davidedmundson, #vdg, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23308: Add a warning message about needing globally installed theme files
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Settings sync only works for theme files that are installed globally. We should add a warning message so users aren't confused when some aspect of the feature doesn't work. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH sync-warning (branched from master) REVISION DETAIL https://phabricator.kde.org/D23308 AFFECTED FILES src/advanceconfig.cpp src/ui/advanceconfig.ui To: filipf Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
