D23414: Remove font configuration from GTK KCM

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Since gtk font settings is now set from Fonts KCM,
  there is no need to configure font separately in
  GTK Configuration KCM.
  
  Depends on D21860 

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  remove-font-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23414

AFFECTED FILES
  CMakeLists.txt
  src/abstractappearance.cpp
  src/abstractappearance.h
  src/appearancegtk2.cpp
  src/appearancegtk3.cpp
  src/appearencegtk.cpp
  src/appearencegtk.h
  src/fontshelpers.cpp
  src/fontshelpers.h
  src/gtkconfigkcmodule.cpp
  src/ui/gui.ui
  tests/configsavetest.cpp

To: gikari
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23414: Remove font configuration from GTK KCM

[Nathaniel Graham]

ngraham added reviewers: apol, Plasma.
ngraham added inline comments.

INLINE COMMENTS

> gui.ui:460
> +
> + ..
> 

Looks unrelated

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D23414

To: gikari, apol, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23414: Remove font configuration from GTK KCM

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> ngraham wrote in gui.ui:460
> Looks unrelated

Hm strange, I only deleted font widgets from Qt Creator. I will fix that 
manually.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D23414

To: gikari, apol, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23414: Remove font configuration from GTK KCM

[Mikhail Zolotukhin]

gikari updated this revision to Diff 64524.
gikari added a comment.


  Fix

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23414?vs=64522&id=64524

BRANCH
  remove-font-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23414

AFFECTED FILES
  CMakeLists.txt
  src/abstractappearance.cpp
  src/abstractappearance.h
  src/appearancegtk2.cpp
  src/appearancegtk3.cpp
  src/appearencegtk.cpp
  src/appearencegtk.h
  src/fontshelpers.cpp
  src/fontshelpers.h
  src/gtkconfigkcmodule.cpp
  src/ui/gui.ui
  tests/configsavetest.cpp

To: gikari, apol, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23414: Remove font configuration from GTK KCM

[Mikhail Zolotukhin]

gikari abandoned this revision.
gikari added a comment.


  Abandoned in favor of D24744 

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D23414

To: gikari, apol, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart