D23520: Add time line to X axis

2019-09-16 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R102:1c7f121073a7: Add time line to X axis (authored by 
alexde, committed by ngraham).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=66063&id=66248

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-14 Thread Alex Debus 
alexde updated this revision to Diff 66063.
alexde added a comment.


  Remove redundant and now wrong comment

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=66062&id=66063

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-14 Thread Alex Debus 
alexde updated this revision to Diff 66062.
alexde added a comment.


  Fix offset calculation for the one hour graph

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=66055&id=66062

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-14 Thread Alex Debus 
alexde added a comment.


  In D23520#531168 , @ngraham wrote:
  
  > Thanks, that's fixed now. However the "Last hour" graph still looks a 
little odd...
  >
  > F7350933: Screenshot_20190914_084935.png 

  
  
  Mm, I cannot reproduce this issue on my side and I cannot explain why you may 
experience it as the code behaves all the same of for all timespans. Very odd.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-14 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks, that's fixed now. However the "Last hour" graph still looks a little 
odd...
  
  F7350933: Screenshot_20190914_084935.png 


REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-14 Thread Alex Debus 
alexde updated this revision to Diff 66055.
alexde added a comment.


  Fix typo in variable and by that make all X axis labels appear again.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=66044&id=66055

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-14 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Hmm, now the X axis labels have disappeared for "Last hour", "Last 2 hours" 
and "Last 12 hours".

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-14 Thread Alex Debus 
alexde updated this revision to Diff 66044.
alexde added a comment.


  The former scaling of the x-Positions of the data points did not fit to the 
time axis.
  Now the x-values of the points, i. e. their timestamps, are correctly aligned.
  
  For some unknown reasons, all data points, which come before/after a certain, 
  abitrary timestamp, seem to have a non-valid timestamp = 0.
  That's why I have added a if-statement to ignore those values.
  
  This feels more like a workaround and the underlying issue should be fixed 
instead in the future.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=66034&id=66044

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-14 Thread Alex Debus 
alexde updated this revision to Diff 66034.
alexde added a comment.


  Remove redundant semicolons and move comment about unit (ms) to the 
declaration of the var

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=66031&id=66034

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-14 Thread Alex Debus 
alexde updated this revision to Diff 66031.
alexde added a comment.


  Use a switch statement for xTicksAt

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65457&id=66031

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-14 Thread Méven Car 
meven added inline comments.

INLINE COMMENTS

> Graph.qml:165
> +
> +if (xTicksAt == xTicksAtTwelveOClock) {
> +diff = ((hours - 12) * 60 * 60 + minutes * 60 + seconds) * 1000 
> // ms

A switch statement should be clearer here.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-09 Thread Alex Debus 
alexde added a comment.


  *Friendly ping to the reviewers.*

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus 
alexde updated this revision to Diff 65457.
alexde added a comment.


  Set correct right border for the grid lines and ticks.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65428&id=65457

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus 
alexde updated this revision to Diff 65428.
alexde added a comment.


  Move stroke() out of the loop.
  Reduce line with by pixel.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65423&id=65428

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus 
alexde updated this revision to Diff 65423.
alexde added a comment.


  Shrink plotWidth a little bit so the earliest date on the right side may fit.
  Change the way the division widths are defined to hopefully make the code 
easier to understand
  and to maintain.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65413&id=65423

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus 
alexde added a comment.


  For some reason the xGridOffset seems sometimes to be wrong, and I have no 
explanation why. It especially happens for 1 hour graphs. F7320671: 
Screenshot_20190905_132313.png 

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus 
alexde requested review of this revision.
alexde added a comment.


  I have changed some stuff, can you please review it again.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus 
alexde updated this revision to Diff 65413.
alexde added a comment.


  Rename variables to make their function clearer.
  Decrease the lower loop border by 1 to make sure that all
  possible grid lines are drawn.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65410&id=65413

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus 
alexde updated this revision to Diff 65410.
alexde added a comment.


  Fix issue that a date may be displayed unintentionally.
  Shrink right margin for grid lines and try to add an additional grid line
  on the right side if reasonable.
  Add more divisions for 2h and 24h graphs.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65409&id=65410

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus 
alexde updated this revision to Diff 65409.
alexde added a comment.


  Use dashed grid lines instead of solid lines. Grid lines with tick labels are 
less faint.
  Rename variable to make its function clearer.
  Show grid lines at all five minutes for the 1 hour graph.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65407&id=65409

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus 
alexde updated this revision to Diff 65407.
alexde added a comment.


  Align grid to 10 minutes for the 1h graph.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65321&id=65407

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-03 Thread Nathaniel Graham 
ngraham added a comment.


  #plasma  people, could we get a code 
review on this?

REPOSITORY
  R102 KInfoCenter

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-03 Thread Alex Debus 
alexde updated this revision to Diff 65320.
alexde added a comment.


  - Set valid defaults.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=64920&id=65320

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-09-03 Thread Alex Debus 
alexde updated this revision to Diff 65321.
alexde added a comment.


  Set valid defaults.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65320&id=65321

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-08-29 Thread fuk sitter 
fuksitter added a comment.


  You think sending your minions to insult me and then disabling my account 
will solve the issue? what will you do next? Disable registration so no one 
points out your hypocrisy? Which overlord made the decision to disable my 
account and for what?

REPOSITORY
  R102 KInfoCenter

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: fuksitter, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-08-29 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Much better. The UI and functionality look great now.
  
  I'll hand this over to the #plasma  
people for code review now.

REPOSITORY
  R102 KInfoCenter

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-08-29 Thread Alex Debus 
alexde added a comment.


  Right now I only display the date under the tick mark if the date has changed 
and the tickmark number is odd, which I think is already good enough for this 
graph.
  However, indicating a date change at midnight (12 pm / 0 am) would make sense 
as well. If you prefer that and find a suitable position for the indicator 
label, I may implemement it.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-08-29 Thread Alex Debus 
alexde updated this revision to Diff 64920.
alexde added a comment.


  Fix displaying wrong variable.
  Add postfix "Str" to indicate that those vars are explicitely strings.
  Make sure that the date is only displayed when date has changed for <= 24h 
graphs.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=64896&id=64920

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-08-28 Thread Nathaniel Graham 
ngraham added a reviewer: Plasma.
ngraham added a comment.


  Wuh-oh, there's something wrong with the date display now: F7290108: 
Screenshot_20190828_161810.png 

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-08-28 Thread Alex Debus 
alexde updated this revision to Diff 64896.
alexde added a comment.


  Improve the formatting's consistancy

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=64892&id=64896

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-08-28 Thread Alex Debus 
alexde updated this revision to Diff 64892.
alexde added a comment.


  Update comment

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=64890&id=64892

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-08-28 Thread Alex Debus 
alexde updated this revision to Diff 64890.
alexde added a comment.


  Omit the date if date equals today and the graph does not range over 24 hours.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=64889&id=64890

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-08-28 Thread Alex Debus 
alexde updated this revision to Diff 64889.
alexde added a comment.


  Resolve formatting issues
  
  - remove semicolons
  - replace tab indention by 4 spaces
  - add space between operator and arguments

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=64840&id=64889

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-08-28 Thread Alex Debus 
alexde added a comment.


  > As you can see, it's kind of funny that only one of the labels has a date 
under it. This is fine for the multi-day graphs, but for the graphs that are 
entirely within the current day, I would recommend omitting the date.
  
  There's actually not such thing as a "single-day" graph. If you look at 0:30 
am at your "1 hour" graph, it will go from 11:30 pm to 0:30 am. :-) 
  But I am fine to omit the dates or at least the current day for all but the 
"48 hour" and "1 week" graphs. Just tell me what you prefer.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-08-28 Thread Nathaniel Graham 
ngraham added a comment.


  Nice!
  
  Only showing the date once per day is clever, but it can be even more clever: 
when all of the times in the graph correspond to the current day, there's no 
need to show it at all. You can see this issue in this screenshot:
  F7289397: Screenshot_20190828_120513.png 

  
  As you can see, it's kind of funny that only one of the labels has a date 
under it. This is fine for the multi-day graphs, but for the graphs that are 
entirely within the current day, I would recommend omitting the date.
  
  Code-wise, there are some formatting issues:
  
  - Don't add semicolons
  - Use 4 spaces for indentation
  - Clean up indentation and make it consistent
  - Add spaces between operators (e.g. `diff / 1000`)

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-08-28 Thread Alex Debus 
alexde updated this revision to Diff 64840.
alexde added a comment.


  Set more sane left/right margins

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=64805&id=64840

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-08-28 Thread Alex Debus 
alexde updated this revision to Diff 64805.
alexde added a comment.


  Set correct default value for a tick position

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=64803&id=64805

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

2019-08-28 Thread Alex Debus 
alexde created this revision.
alexde added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alexde requested review of this revision.

REVISION SUMMARY
  The current energy plot does not display any time line. This patch adds a 
grid and time stamps to the X axis.
  It is assumed that the X axis of the plot ranges from [Now - Timespan, Now].
  The timestamps for the timespans greater than "1 hour" are aligned to either 
half hours or full hours. 
  The resolution respectively the divisions count or number of ticks is made 
dependend on the timespan.
  Dates are only shown if the date changes in the timespan.
  
  This patch may be only of temporary nature until kf5quickcharts 
 becomes production ready.
  
  As QML was absolutely new to me, I am looking forward to your review.

REPOSITORY
  R102 KInfoCenter

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart